fix: Properly report template errors.

api/v1beta1/common.go

@@ -31,3 +31,11 @@ type HandOverError struct {
 func (r *HandOverError) Error() string {
 	return r.Message
 }
+
+type TemplateInstantiationError struct {
+	Message string
+}
+
+func (r *TemplateInstantiationError) Error() string {
+	return r.Message
+}

controllers/clustersummary_controller.go

@@ -297,6 +297,11 @@ func (r *ClusterSummaryReconciler) reconcileDelete(
 			if errors.As(err, &nonRetriableError) {
 				return reconcile.Result{Requeue: true, RequeueAfter: deleteHandOverRequeueAfter}, nil
 			}
+
+			var templateError *configv1beta1.TemplateInstantiationError
+			if errors.As(err, &templateError) {
+				return reconcile.Result{Requeue: true, RequeueAfter: deleteHandOverRequeueAfter}, nil
+			}
 		}
 
 		if !r.canRemoveFinalizer(ctx, clusterSummaryScope, logger) {
@@ -363,9 +368,9 @@ func (r *ClusterSummaryReconciler) reconcileNormal(ctx context.Context,
 		return reconcile.Result{}, nil
 	}
 
-	err = r.updateMaps(ctx, clusterSummaryScope, logger)
-	if err != nil {
-		return reconcile.Result{}, err
+	updateMapErrs := r.updateMaps(ctx, clusterSummaryScope, logger)
+	if updateMapErrs != nil {
+		logger.V(logs.LogInfo).Error(updateMapErrs, "failed to get referenced resources")
 	}
 
 	paused, err := r.isPaused(ctx, clusterSummaryScope.ClusterSummary)

controllers/clustersummary_deployer.go

@@ -171,6 +171,12 @@ func (r *ClusterSummaryReconciler) proceedDeployingFeature(ctx context.Context,
 				r.updateFeatureStatus(clusterSummaryScope, f.id, &nonRetriableStatus, currentHash, deployerError, logger)
 				return nil
 			}
+			var templateError *configv1beta1.TemplateInstantiationError
+			if errors.As(deployerError, &templateError) {
+				nonRetriableStatus := libsveltosv1beta1.FeatureStatusFailedNonRetriable
+				r.updateFeatureStatus(clusterSummaryScope, f.id, &nonRetriableStatus, currentHash, deployerError, logger)
+				return nil
+			}
 			if r.maxNumberOfConsecutiveFailureReached(clusterSummaryScope, f, logger) {
 				nonRetriableStatus := libsveltosv1beta1.FeatureStatusFailedNonRetriable
 				resultError := errors.New("the maximum number of consecutive errors has been reached")
@@ -412,6 +418,12 @@ func (r *ClusterSummaryReconciler) processUndeployResult(ctx context.Context, cl
 			r.updateFeatureStatus(clusterSummaryScope, f.id, &removing, nil, result.Err, logger)
 			return result.Err
 		}
+		var templateError *configv1beta1.TemplateInstantiationError
+		if errors.As(result.Err, &templateError) {
+			removing := libsveltosv1beta1.FeatureStatusRemoving
+			r.updateFeatureStatus(clusterSummaryScope, f.id, &removing, nil, result.Err, logger)
+			return result.Err
+		}
 
 		if *status == libsveltosv1beta1.FeatureStatusRemoved {
 			if isPullMode {

controllers/handlers_helm.go

@@ -734,13 +734,19 @@ func helmHash(ctx context.Context, c client.Client, clusterSummary *configv1beta
 			namespace, err := libsveltostemplate.GetReferenceResourceNamespace(ctx, c,
 				clusterNamespace, clusterName, sourceRef.Namespace, clusterType)
 			if err != nil {
-				return nil, err
+				logger.V(logs.LogInfo).Info(fmt.Sprintf("failed to instantiate namespace for %s: %v",
+					sourceRef.Namespace, err))
+				// Ignore template instantiation error
+				continue
 			}
 
 			name, err := libsveltostemplate.GetReferenceResourceName(ctx, c,
 				clusterNamespace, clusterName, sourceRef.Name, clusterType)
 			if err != nil {
-				return nil, err
+				logger.V(logs.LogInfo).Info(fmt.Sprintf("failed to instantiate name for %s: %v",
+					sourceRef.Name, err))
+				// Ignore template instantiation error
+				continue
 			}
 
 			source, err := getSource(ctx, c, namespace, name, sourceRef.Kind)
@@ -3989,13 +3995,16 @@ func getInstantiatedChart(ctx context.Context, clusterSummary *configv1beta1.Clu
 	objects, err := fecthClusterObjects(ctx, getManagementClusterConfig(), getManagementClusterClient(),
 		clusterSummary.Spec.ClusterNamespace, clusterSummary.Spec.ClusterName, clusterSummary.Spec.ClusterType, logger)
 	if err != nil {
+		logger.V(logs.LogInfo).Error(err, "failed to fetch resources")
 		return nil, err
 	}
 
 	// Call the new recursive helper function to instantiate all fields.
 	if err := instantiateStructFields(ctx, getManagementClusterConfig(), getManagementClusterClient(),
 		instantiatedChart, clusterSummary, objects, mgmtResources, logger); err != nil {
-		return nil, err
+		msg := fmt.Sprintf("failed to instantiated template: %v", err)
+		logger.V(logs.LogInfo).Info(msg)
+		return nil, &configv1beta1.TemplateInstantiationError{Message: msg}
 	}
 
 	return instantiatedChart, nil

controllers/handlers_kustomize.go

@@ -399,6 +399,9 @@ func kustomizationHash(ctx context.Context, c client.Client, clusterSummary *con
 		if err != nil {
 			return nil, err
 		}
+		if result == nil {
+			continue
+		}
 		config += string(result)
 
 		valueFromHash, err := getKustomizeReferenceResourceHash(ctx, c, clusterSummary,
@@ -430,13 +433,19 @@ func getHashFromKustomizationRef(ctx context.Context, c client.Client, clusterSu
 	namespace, err := libsveltostemplate.GetReferenceResourceNamespace(ctx, c, clusterSummary.Spec.ClusterNamespace,
 		clusterSummary.Spec.ClusterName, kustomizationRef.Namespace, clusterSummary.Spec.ClusterType)
 	if err != nil {
-		return nil, err
+		logger.V(logs.LogInfo).Info(fmt.Sprintf("failed to instantiate namespace for %s: %v",
+			kustomizationRef.Namespace, err))
+		// Ignore template instantiation error
+		return nil, nil
 	}
 
 	name, err := libsveltostemplate.GetReferenceResourceName(ctx, c, clusterSummary.Spec.ClusterNamespace,
 		clusterSummary.Spec.ClusterName, kustomizationRef.Name, clusterSummary.Spec.ClusterType)
 	if err != nil {
-		return nil, err
+		logger.V(logs.LogInfo).Info(fmt.Sprintf("failed to instantiate name for %s: %v",
+			kustomizationRef.Name, err))
+		// Ignore template instantiation error
+		return nil, nil
 	}
 
 	if kustomizationRef.Kind == string(libsveltosv1beta1.ConfigMapReferencedResourceKind) {
@@ -676,13 +685,13 @@ func prepareFileSystem(ctx context.Context, c client.Client,
 	namespace, err := libsveltostemplate.GetReferenceResourceNamespace(ctx, c, clusterSummary.Spec.ClusterNamespace,
 		clusterSummary.Spec.ClusterName, kustomizationRef.Namespace, clusterSummary.Spec.ClusterType)
 	if err != nil {
-		return "", err
+		return "", &configv1beta1.TemplateInstantiationError{Message: err.Error()}
 	}
 
 	name, err := libsveltostemplate.GetReferenceResourceName(ctx, c, clusterSummary.Spec.ClusterNamespace,
 		clusterSummary.Spec.ClusterName, kustomizationRef.Name, clusterSummary.Spec.ClusterType)
 	if err != nil {
-		return "", err
+		return "", &configv1beta1.TemplateInstantiationError{Message: err.Error()}
 	}
 
 	source, err := getSource(ctx, c, namespace, name, kustomizationRef.Kind)

controllers/handlers_resources.go

@@ -499,7 +499,7 @@ func resourcesHash(ctx context.Context, c client.Client, clusterSummary *configv
 	var config string
 	config += string(clusterProfileSpecHash)
 
-	referencedObjects := make([]corev1.ObjectReference, len(clusterSummary.Spec.ClusterProfileSpec.PolicyRefs))
+	referencedObjects := make([]corev1.ObjectReference, 0, len(clusterSummary.Spec.ClusterProfileSpec.PolicyRefs))
 	for i := range clusterSummary.Spec.ClusterProfileSpec.PolicyRefs {
 		reference := &clusterSummary.Spec.ClusterProfileSpec.PolicyRefs[i]
 		namespace, err := libsveltostemplate.GetReferenceResourceNamespace(ctx, c,
@@ -508,22 +508,24 @@ func resourcesHash(ctx context.Context, c client.Client, clusterSummary *configv
 		if err != nil {
 			logger.V(logs.LogInfo).Info(fmt.Sprintf("failed to instantiate namespace for %s %s/%s: %v",
 				reference.Kind, reference.Namespace, reference.Name, err))
-			return nil, err
+			// Ignore template instantiation error
+			continue
 		}
 
 		name, err := libsveltostemplate.GetReferenceResourceName(ctx, c, clusterSummary.Spec.ClusterNamespace,
 			clusterSummary.Spec.ClusterName, reference.Name, clusterSummary.Spec.ClusterType)
 		if err != nil {
 			logger.V(logs.LogInfo).Info(fmt.Sprintf("failed to instantiate name for %s %s/%s: %v",
 				reference.Kind, reference.Namespace, reference.Name, err))
-			return nil, err
+			// Ignore template instantiation error
+			continue
 		}
 
-		referencedObjects[i] = corev1.ObjectReference{
+		referencedObjects = append(referencedObjects, corev1.ObjectReference{
 			Kind:      clusterSummary.Spec.ClusterProfileSpec.PolicyRefs[i].Kind,
 			Namespace: namespace,
 			Name:      name,
-		}
+		})
 	}
 
 	sort.Sort(dependencymanager.SortedCorev1ObjectReference(referencedObjects))

controllers/handlers_utils.go

@@ -676,18 +676,20 @@ func collectReferencedObjects(ctx context.Context, controlClusterClient client.C
 			clusterSummary.Spec.ClusterNamespace, clusterSummary.Spec.ClusterName, references[i].Namespace,
 			clusterSummary.Spec.ClusterType)
 		if err != nil {
-			logger.V(logs.LogInfo).Info(fmt.Sprintf("failed to instantiate namespace for %s %s/%s: %v",
-				reference.Kind, reference.Namespace, reference.Name, err))
-			return nil, nil, err
+			msg := fmt.Sprintf("failed to instantiate namespace for %s %s/%s: %v",
+				reference.Kind, reference.Namespace, reference.Name, err)
+			logger.V(logs.LogInfo).Info(msg)
+			return nil, nil, &configv1beta1.TemplateInstantiationError{Message: msg}
 		}
 
 		name, err := libsveltostemplate.GetReferenceResourceName(ctx, getManagementClusterClient(),
 			clusterSummary.Spec.ClusterNamespace, clusterSummary.Spec.ClusterName, references[i].Name,
 			clusterSummary.Spec.ClusterType)
 		if err != nil {
-			logger.V(logs.LogInfo).Info(fmt.Sprintf("failed to instantiate name for %s %s/%s: %v",
-				reference.Kind, reference.Namespace, reference.Name, err))
-			return nil, nil, err
+			msg := fmt.Sprintf("failed to instantiate name for %s %s/%s: %v",
+				reference.Kind, reference.Namespace, reference.Name, err)
+			logger.V(logs.LogInfo).Info(msg)
+			return nil, nil, &configv1beta1.TemplateInstantiationError{Message: msg}
 		}
 
 		if reference.Kind == string(libsveltosv1beta1.ConfigMapReferencedResourceKind) {