fix: Properly report template errors. #1419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, template errors (in PolicyRefs, KustomizationRefs, or HelmCharts) caused a poor user experience: 1. The ClusterSummary Status was never updated, hiding the error from the resource status (visible only in logs). 2. The controller continuously returned a retryable error, causing the ClusterSummary to be aggressively reconciled followed by long, unpredictable delays. This PR improves stability and visibility by: 1. Setting the ClusterSummary Status with the precise template error. 2. Reporting the error as non-retryable to stop the aggressive requeueing. This approach ensures the system doesn't waste resources constantly processing an unfixable error, requiring the user to explicitly update the ClusterProfile to resolve the issue. While some template errors might auto-resolve (e.g., a missing Cluster label being added), preventing constant requeueing is the preferred, stable behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, template errors (in PolicyRefs,
KustomizationRefs, or HelmCharts) caused a poor user experience:
This PR improves stability and visibility by:
This approach ensures the system doesn't waste resources constantly processing an unfixable error, requiring the user to explicitly update the ClusterProfile to resolve the issue.
While some template errors might auto-resolve (e.g., a missing Cluster label being added), preventing constant requeueing is the preferred, stable behavior.