feat: Detox simulator test runner

.changeset/khaki-bottles-sniff.md

@@ -0,0 +1,5 @@
+---
+'@powersync/op-sqlite': patch
+---
+
+Rejecting pending read/write operations when the database is closed.

.changeset/light-oranges-compete.md

@@ -0,0 +1,5 @@
+---
+'@powersync/op-sqlite': minor
+---
+
+`close()` is now async, which allows clients to use it with `await`.

.github/workflows/test-simulators.yaml

@@ -0,0 +1,205 @@
+# Ensures certain packages work on simulators
+name: Test Simulators/Emulators
+on:
+  pull_request: # triggered for any PR updates (including new pushes to PR branch)
+
+jobs:
+  check-changes:
+    name: Check for relevant changes
+    runs-on: ubuntu-latest
+    outputs:
+      should_run: ${{ steps.check.outputs.should_run }}
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Check for changes
+        id: check
+        run: |
+          git fetch origin ${{ github.base_ref }}
+          if git diff --quiet origin/${{ github.base_ref }} -- packages/common packages/powersync-op-sqlite; then
+            echo "should_run=false" >> $GITHUB_OUTPUT
+          else
+            echo "should_run=true" >> $GITHUB_OUTPUT
+          fi
+
+  test-android:
+    name: Test Android
+    needs: check-changes
+    if: ${{ needs.check-changes.outputs.should_run == 'true' }}
+    runs-on: ubuntu-xl
+    env:
+      AVD_NAME: ubuntu-avd-x86_64-31
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+
+      - name: Enable KVM group perms
+        run: |
+          echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules
+          sudo udevadm control --reload-rules
+          sudo udevadm trigger --name-match=kvm
+
+      - name: Setup Gradle
+        uses: gradle/actions/setup-gradle@v4
+
+      - name: AVD Cache
+        uses: actions/cache@v3
+        id: avd-cache
+        with:
+          path: |
+            ~/.android/avd/*
+            ~/.android/adb*
+          key: avd-31
+
+      - name: Set up JDK 17
+        uses: actions/setup-java@v3
+        with:
+          java-version: 17
+          distribution: 'adopt'
+          cache: 'gradle'
+
+      - name: Setup NodeJS
+        uses: actions/setup-node@v4
+        with:
+          node-version-file: '.nvmrc'
+
+      - uses: pnpm/action-setup@v2
+        name: Install pnpm
+        with:
+          version: 9
+          run_install: false
+
+      - name: Get pnpm store directory
+        shell: bash
+        run: |
+          echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
+
+      - uses: actions/cache@v3
+        name: Setup pnpm cache
+        with:
+          path: ${{ env.STORE_PATH }}
+          key: ${{ runner.os }}-pnpm-store-${{ hashFiles('pnpm-lock.yaml') }}
+          restore-keys: |
+            ${{ runner.os }}-pnpm-store-
+
+      - name: Install dependencies
+        run: pnpm install
+
+      - name: Build
+        run: pnpm build:packages
+
+      - name: Setup Detox build framework cache
+        working-directory: ./tools/powersynctests
+        run: |
+          pnpx detox clean-framework-cache && pnpx detox build-framework-cache
+
+      - name: Initialize Android Folder
+        run: mkdir -p ~/.android/avd
+
+      - name: create AVD and generate snapshot for caching
+        if: steps.avd-cache.outputs.cache-hit != 'true'
+        uses: reactivecircus/android-emulator-runner@v2.28.0
+        with:
+          api-level: 31
+          force-avd-creation: false
+          target: google_apis
+          arch: x86_64
+          disable-animations: false
+          avd-name: $AVD_NAME
+          emulator-options: -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
+          script: echo "Generated AVD snapshot for caching."
+
+      - name: Android Emulator Build
+        working-directory: ./tools/powersynctests
+        run: pnpx detox build --configuration android.emu.release
+
+      - name: Run connected Android tests
+        uses: ReactiveCircus/android-emulator-runner@v2.28.0
+        with:
+          api-level: 31
+          target: google_apis
+          arch: x86_64
+          avd-name: $AVD_NAME
+          script: cd tools/powersynctests && pnpx detox test --configuration android.emu.release --headless
+          force-avd-creation: false
+          emulator-options: -no-snapshot-save -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
+          disable-animations: true
+
+  test-ios:
+    name: Test iOS
+    needs: check-changes
+    if: ${{ needs.check-changes.outputs.should_run == 'true' }}
+    runs-on: macOS-15
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+
+      - name: CocoaPods Cache
+        uses: actions/cache@v3
+        id: cocoapods-cache
+        with:
+          path: |
+            tools/powersynctests/ios/Pods/*
+          key: ${{ runner.os }}-${{ hashFiles('tools/powersynctests/ios/Podfile.lock') }}
+
+      - name: Cache Xcode Derived Data
+        uses: actions/cache@v3
+        with:
+          path: |
+            tools/powersynctests/ios/build/*
+          key: xcode-derived-${{ runner.os }}-${{ hashFiles('tools/powersynctests/ios/Podfile.lock') }}
+          restore-keys: |
+            xcode-derived-${{ runner.os }}-
+
+      - name: Setup NodeJS
+        uses: actions/setup-node@v4
+        with:
+          node-version-file: '.nvmrc'
+
+      - uses: pnpm/action-setup@v2
+        name: Install pnpm
+        with:
+          version: 9
+          run_install: false
+
+      - name: Get pnpm store directory
+        shell: bash
+        run: |
+          echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
+
+      - uses: actions/cache@v3
+        name: Setup pnpm cache
+        with:
+          path: ${{ env.STORE_PATH }}
+          key: ${{ runner.os }}-pnpm-store-${{ hashFiles('pnpm-lock.yaml') }}
+          restore-keys: |
+            ${{ runner.os }}-pnpm-store-
+
+      - name: Install dependencies
+        run: pnpm install
+
+      - name: Build
+        run: pnpm build:packages
+
+      - name: Install Detox dependencies
+        run: |
+          brew tap wix/brew
+          brew install applesimutils
+          npm install -g detox-cli
+          detox clean-framework-cache && detox build-framework-cache
+
+      - name: Install CocoaPods dependencies
+        working-directory: tools/powersynctests/ios
+        run: pod install
+
+      - name: iOS Simulator Build
+        working-directory: ./tools/powersynctests
+        run: pnpx detox build --configuration ios.sim.release
+
+      - name: iOS Simulator Test
+        working-directory: ./tools/powersynctests
+        run: pnpx detox test --configuration ios.sim.release --cleanup

packages/powersync-op-sqlite/src/db/OPSqliteAdapter.ts

@@ -1,8 +1,8 @@
-import { BaseObserver, DBAdapter, DBAdapterListener, DBLockOptions, QueryResult, Transaction } from '@powersync/common';
 import { ANDROID_DATABASE_PATH, getDylibPath, IOS_LIBRARY_PATH, open, type DB } from '@op-engineering/op-sqlite';
+import { BaseObserver, DBAdapter, DBAdapterListener, DBLockOptions, QueryResult, Transaction } from '@powersync/common';
 import Lock from 'async-lock';
-import { OPSQLiteConnection } from './OPSQLiteConnection';
 import { Platform } from 'react-native';
+import { OPSQLiteConnection } from './OPSQLiteConnection';
 import { SqliteOptions } from './SqliteOptions';
 
 /**
@@ -32,6 +32,7 @@ export class OPSQLiteDBAdapter extends BaseObserver<DBAdapterListener> implement
   protected writeConnection: OPSQLiteConnection | null;
 
   private readQueue: Array<() => void> = [];
+  private abortController: AbortController;
 
   constructor(protected options: OPSQLiteAdapterOptions) {
     super();
@@ -40,6 +41,7 @@ export class OPSQLiteDBAdapter extends BaseObserver<DBAdapterListener> implement
     this.locks = new Lock();
     this.readConnections = null;
     this.writeConnection = null;
+    this.abortController = new AbortController();
     this.initialized = this.init();
   }
 
@@ -153,11 +155,14 @@ export class OPSQLiteDBAdapter extends BaseObserver<DBAdapterListener> implement
     }
   }
 
-  close() {
-    this.initialized.then(() => {
-      this.writeConnection!.close();
-      this.readConnections!.forEach((c) => c.connection.close());
-    });
+  async close() {
+    await this.initialized;
+    // Abort any pending operations
+    this.abortController.abort();
+    this.readQueue = [];
+
+    this.writeConnection!.close();
+    this.readConnections!.forEach((c) => c.connection.close());
   }
 
   async readLock<T>(fn: (tx: OPSQLiteConnection) => Promise<T>, options?: DBLockOptions): Promise<T> {
@@ -203,17 +208,30 @@ export class OPSQLiteDBAdapter extends BaseObserver<DBAdapterListener> implement
 
     return new Promise(async (resolve, reject) => {
       try {
+        // Set up abort signal listener
+        const abortListener = () => {
+          reject(new Error('Database connection was closed'));
+        };
+        this.abortController.signal.addEventListener('abort', abortListener);
+
         await this.locks
           .acquire(
             LockType.WRITE,
             async () => {
+              // Check if operation was aborted before executing
+              if (this.abortController.signal.aborted) {
+                reject(new Error('Database connection was closed'));
+              }
               resolve(await fn(this.writeConnection!));
             },
             { timeout: options?.timeoutMs }
           )
           .then(() => {
             // flush updates once a write lock has been released
             this.writeConnection!.flushUpdates();
+          })
+          .finally(() => {
+            this.abortController.signal.removeEventListener('abort', abortListener);
           });
       } catch (ex) {
         reject(ex);