Skip to content

feat: Detox simulator test runner #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
May 28, 2025
Merged

feat: Detox simulator test runner #590

merged 34 commits into from
May 28, 2025

Conversation

Chriztiaan
Copy link
Contributor

@Chriztiaan Chriztiaan commented May 7, 2025

Descriptions

This PR introduces an OP-SQLITE adapter test suite that works in a similar way to RNQS. This project's setup differs quite a bit though as it is Detox based, but still runs tests against a simulator. At the moment only the iOS simulator is being used.

The tests are pulled into a single Detox test, an interaction in the UI kicks off all the tests and we pull the state of each test out of the UI which then gets reported - any failures will cause the single Detox test to fail.

image

Considerations

I am not sure whether this and future simulator/emulator Github actions should run on PR as they do take a bit longer than our other actions, it's good to have them regardless. They also seem to be nondeterministically unstable.

Future work

  • Also run tests against the RNQS adapter, might need a second workflow so that you can do a pod install with a separate set of dependencies (without op-sqlite)

Copy link

changeset-bot bot commented May 7, 2025

🦋 Changeset detected

Latest commit: c38064c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@powersync/op-sqlite Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Chriztiaan Chriztiaan requested a review from stevensJourney May 7, 2025 12:48
@Chriztiaan Chriztiaan marked this pull request as ready for review May 7, 2025 13:01
Copy link
Collaborator

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor comments. Overall this is pretty cool.
Android tests should be possible as discussed offline.

stevensJourney
stevensJourney previously approved these changes May 27, 2025
Copy link
Collaborator

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with these changes from my side.

@Chriztiaan Chriztiaan merged commit 1037e8a into main May 28, 2025
9 checks passed
@Chriztiaan Chriztiaan deleted the op-sqlite-tests branch May 28, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants