-
Notifications
You must be signed in to change notification settings - Fork 46
feat: Detox simulator test runner #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: c38064c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some minor comments. Overall this is pretty cool.
Android tests should be possible as discussed offline.
… from root config.
…s into op-sqlite-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with these changes from my side.
Descriptions
This PR introduces an OP-SQLITE adapter test suite that works in a similar way to RNQS. This project's setup differs quite a bit though as it is Detox based, but still runs tests against a simulator. At the moment only the iOS simulator is being used.
The tests are pulled into a single Detox test, an interaction in the UI kicks off all the tests and we pull the state of each test out of the UI which then gets reported - any failures will cause the single Detox test to fail.
Considerations
I am not sure whether this and future simulator/emulator Github actions should run on
PR
as they do take a bit longer than our other actions, it's good to have them regardless. They also seem to be nondeterministically unstable.Future work