Skip to content

Upgrade react-image-editor to SPFX 1.21.1 and Node 22 #5464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions samples/react-image-editor/.devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "SPFx 1.20.0",
"image": "docker.io/m365pnp/spfx:1.20.0",
"name": "SPFx 1.21.1",
"image": "docker.io/m365pnp/spfx:1.21.1",
"customizations": {
"vscode": {
"extensions": [
Expand Down
2 changes: 1 addition & 1 deletion samples/react-image-editor/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18.20.3
v22.14.0
4 changes: 2 additions & 2 deletions samples/react-image-editor/.yo-rc.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
"@microsoft/generator-sharepoint": {
"plusBeta": false,
"isCreatingSolution": true,
"nodeVersion": "18.20.3",
"nodeVersion": "22.14.0",
"sdksVersions": {
"@microsoft/microsoft-graph-client": "3.0.2",
"@microsoft/teams-js": "2.24.0"
},
"version": "1.20.0",
"version": "1.21.1",
"environment": "spo",
"libraryName": "react-image-editor",
"libraryId": "e859f86f-7a12-40e3-94fb-97ee47419aed",
Expand Down
6 changes: 4 additions & 2 deletions samples/react-image-editor/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ The Placeholder and FilePicker are components from the [sp-dev-fx-controls-react
| Every SPFx version is only compatible with specific version(s) of Node.js. In order to be able to build this sample, please ensure that the version of Node on your workstation matches one of the versions listed in this section. This sample will not work on a different version of Node.|
|Refer to <https://aka.ms/spfx-matrix> for more information on SPFx compatibility. |

![SPFx 1.20](https://img.shields.io/badge/SPFx-1.10.0-green.svg)
![Node.js LTS 18](https://img.shields.io/badge/Node.js-LTS%2018-green.svg)
![SPFx 1.21.1](https://img.shields.io/badge/SPFx-1.21.1-green.svg)
![Node.js LTS 22](https://img.shields.io/badge/Node.js-LTS%2022-green.svg)
![Compatible with SharePoint Online](https://img.shields.io/badge/SharePoint%20Online-Compatible-green.svg)
![Does not work with SharePoint 2019](https://img.shields.io/badge/SharePoint%20Server%202019-Incompatible-red.svg "SharePoint Server 2019 requires SPFx 1.4.1 or lower")
![Does not work with SharePoint 2016 (Feature Pack 2)](https://img.shields.io/badge/SharePoint%20Server%202016%20(Feature%20Pack%202)-Incompatible-red.svg "SharePoint Server 2016 Feature Pack 2 requires SPFx 1.1")
Expand Down Expand Up @@ -75,6 +75,8 @@ The Placeholder and FilePicker are components from the [sp-dev-fx-controls-react

|Version|Date|Comments|
|-------|----|--------|
|2.0.1.0|Mai 5, 2025| SPFx 1.21.1|
|2.0.1.0|Apr 27, 2025|Node Version SPFx 1.21|
|2.0.0.0|Apr 02, 2025|Added properties and accessibility|
|1.1.0.0|Sep 09, 2024|Added properties and accessibility|
|1.0.0.0|Mar 17, 2021|Initial release|
Expand Down
2 changes: 1 addition & 1 deletion samples/react-image-editor/assets/sample.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
},
{
"key": "SPFX-VERSION",
"value": "1.20.0"
"value": "1.21.1"
},
{
"key": "SPFX-TEAMSTAB",
Expand Down
4 changes: 2 additions & 2 deletions samples/react-image-editor/config/package-solution.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"solution": {
"name": "react-image-editor-client-side-solution",
"id": "e859f86f-7a12-40e3-94fb-97ee47419aed",
"version": "2.0.0.0",
"version": "2.0.2.0",
"includeClientSideAssets": true,
"skipFeatureDeployment": true,
"isDomainIsolated": false,
Expand All @@ -12,7 +12,7 @@
"websiteUrl": "",
"privacyUrl": "",
"termsOfUseUrl": "",
"mpnId": "Undefined-1.20.0"
"mpnId": "Undefined-1.21.1"
},
"metadata": {
"shortDescription": {
Expand Down
2 changes: 1 addition & 1 deletion samples/react-image-editor/gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ build.rig.getTasks = function () {
return result;
};

build.initialize(require('gulp'));
build.initialize(require('gulp'));
Loading
Loading