Skip to content

Upgrade react-image-editor to SPFX 1.21.1 and Node 22 #5464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025

Conversation

petkir
Copy link
Contributor

@petkir petkir commented Apr 28, 2025

  • Bug fix/update

What's in this Pull Request?

SPFX 1.20 to 1.21.1 upgrade

Node Version

Node version used:
v22.14.0

Checklist

  • My pull request affects only ONE sample.
  • My sample builds without any warnings
  • I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • My solution includes a .nvmrc file indicating the version of Node.js

@petkir petkir changed the title Css and gulp bugfix Upgrade react-image-editor to SPFX 1.21 and Node 22 Apr 28, 2025
Copy link

Sample PR validation for #5464

⚠️ Validation status: warnings

We automatically validate all pull requests against our contribution guidance to ensure that all samples provide a consistent experience to our community.

In order to merge this PR in a timely manner, the following criteria must be met:

Validation Status
Pull request affects only one folder ✅ Succeeded
Sample folder name follows naming convention ✅ Succeeded
README.md contains visitor stat image ✅ Succeeded
Sample requires a .nvmrc file ✅ Succeeded
Sample requires a README.md ✅ Succeeded
Sample requires a screenshot .png in assets folder ⚠️ Warning
No .sppkg file ✅ Succeeded
No node_modules folder ✅ Succeeded
No lib folder ✅ Succeeded

@petkir please address the above issues and push new changes to this branch.
For more information, see the contribution guidance.

@petkir petkir changed the title Upgrade react-image-editor to SPFX 1.21 and Node 22 Upgrade react-image-editor to SPFX 1.21.1 and Node 22 May 5, 2025
Copy link

github-actions bot commented May 5, 2025

Sample PR validation for #5464

⚠️ Validation status: warnings

We automatically validate all pull requests against our contribution guidance to ensure that all samples provide a consistent experience to our community.

In order to merge this PR in a timely manner, the following criteria must be met:

Validation Status
Pull request affects only one folder ✅ Succeeded
Sample folder name follows naming convention ✅ Succeeded
README.md contains visitor stat image ✅ Succeeded
Sample requires a .nvmrc file ✅ Succeeded
Sample requires a README.md ✅ Succeeded
Sample requires a screenshot .png in assets folder ⚠️ Warning
No .sppkg file ✅ Succeeded
No node_modules folder ✅ Succeeded
No lib folder ✅ Succeeded

@petkir please address the above issues and push new changes to this branch.
For more information, see the contribution guidance.

@hugoabernier hugoabernier merged commit e9c2593 into pnp:main May 15, 2025
4 checks passed
@hugoabernier
Copy link
Collaborator

Thanks @petkir for your update! Awesome!.

Thank you for sharing your sample with others - you rock! 👏🥇👩‍💻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants