Skip to content

Add 6.2 upgrade for the use_ajax setting of the ISiteSchema controlpanel #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2025
Merged

Add 6.2 upgrade for the use_ajax setting of the ISiteSchema controlpanel #345

merged 1 commit into from
Sep 23, 2025

Conversation

thet
Copy link
Member

@thet thet commented Jun 23, 2025 •
edited
Loading

@mister-roboto
Copy link

@thet thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@thet thet mentioned this pull request Jun 23, 2025
Merged
@thet thet marked this pull request as draft June 23, 2025 23:52
@thet thet mentioned this pull request Jun 24, 2025
Merged
@thet thet mentioned this pull request Sep 22, 2025
Merged
@thet thet marked this pull request as ready for review September 22, 2025 00:37
@thet thet mentioned this pull request Sep 22, 2025
Merged
@thet thet requested a review from davisagli September 22, 2025 00:42
davisagli
davisagli reviewed Sep 22, 2025
View reviewed changes
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay -- but see my comment on plone/plone.base#87 (review)

@thet thet mentioned this pull request Sep 22, 2025
Merged
@thet thet mentioned this pull request Sep 23, 2025
Merged
@thet thet merged commit 885b632 into master Sep 23, 2025
13 checks passed
@thet thet deleted the ajax_marker branch September 23, 2025 16:26
@davisagli
Copy link
Member

@thet This broke the CMFPlone tests because the new upgrade profile was not hidden from the add-ons control panel. Fixed in 516900c

Please run the jenkins jobs next time. I guess I should add it as a required check for this repository so that it shows up in the list on a pull request. Okay, I did that. FYI @mauritsvanrees

@thet
Copy link
Member Author

thet commented Sep 23, 2025

@davisagli oh no, sorry for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davisagli davisagli davisagli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thet @mister-roboto @davisagli