Expose the IClassicUISchema registry setting use_ajax_main_template in the theming control panel.
#265
Conversation
|
@thet thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
thet
changed the title
IClassicUISchema registry setting ``use_ajax_main_temp…IClassicUISchema registry setting use_ajax_main_template in the theming control panel.
|
@davisagli that's right - here it is: plone/buildout.coredev#1037 |
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
…late`` in the theming control panel.
|
@jenkins-plone-org please run jobs |
The new IClassicUISchema.use_ajax_main_template setting needs latest plone.base 4.0.0a1 which is part of CMFPlone 6.2.
|
@jenkins-plone-org please run jobs |
Otherwise you get a test failure:
```
File "/home/runner/work/plone.app.theming/plone.app.theming/src/plone/app/theming/browser/controlpanel.py", line 223, in update
self.use_ajax_main_template = use_ajax_main_template
File "/home/runner/work/plone.app.theming/plone.app.theming/src/plone/app/theming/browser/controlpanel.py", line 113, in set_use_ajax_main_template
self.classicui_settings.use_ajax_main_template = value
File "/home/runner/work/plone.app.theming/plone.app.theming/.tox/py313-plone62/lib/python3.13/site-packages/plone/registry/recordsproxy.py", line 47, in __setattr__
raise AttributeError(name)
AttributeError: use_ajax_main_template
```
This is needed until we have a 6.2 alpha release.
|
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
GHA is green now. Waiting for Jenkins for good measure. Can be merged when green.
And I finally tested it in a Python prompt and it works, resulting in a shorter html:
>>> import requests
>>> normal = requests.get("http://localhost:8080/Plone11/news")
>>> xhr = requests.get("http://localhost:8080/Plone11/news", headers={"X-REQUESTED-WITH": "XMLHttpRequest"})
>>> len(normal.text)
11164
>>> len(xhr.text)
5254
4 participants
UI
Related PRs
plone/Products.CMFPlone#4169
plone/plone.app.layout#405
plone/plone.base#87
#265
plone/plone.app.upgrade#345
plone/buildout.coredev#1036
plone/buildout.coredev#1037