Fix: Handle run_in_parallel=False, simplify pending function call tra… #145
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
||
| # Check if all function calls are complete using Pipecat's state | ||
| assistant_aggregator = self._context_aggregator.assistant() | ||
| if not assistant_aggregator._function_calls_in_progress: |
There was a problem hiding this comment.
I don't usually like relying on private state, as implementation can change at any time. If we want Pipecat to be telling us whether function calls are still in progress, should we first expose that as part of the API before relying on it here?
There was a problem hiding this comment.
Yes, I think we have to. Currently, only Pipecat—in its internal state—knows about which function calls are in progress. I'll expose this via Pipecat in a separate PR.
There was a problem hiding this comment.
Definitely a nice simplification (though admittedly I haven't spent the time yet to fully grok the need for all the in-flight-function tracking in the first place). I've documented one concern I had so far.
You're right that we'll have to do some merge conflict resolution with #141.
|
Closing in favor of #147 |
…cking
This is going to conflict with #141 but I wanted to work through how to fix this problem given the current code. We can figure out how to make this work with the new logic, as it offers a way to simplify the logic overall.
Crucially, this defers the pending function calling logic to Pipecat, which offers a means for Pipecat Flows to be simplified.
cc @kompfner happy to discuss!