Mb/func simple handle run in parallel #146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… provide Python functions as NodeConfig functions. When direct functions are used: - Function name, description, properties, and required are all automatically read from the Python function signature and docstring - There’s no need for separate handler and transition callbacks
…ot be conflated with being required (that should happen by way of a default argument)
…working! Still more work to do before it’s ready, though
…f “unified” functions (functions that return both result and next_node, obviating the need to use `transition_to`/`transition_callback`) and “direct” functions (functions that are provided in lieu of function declarations/`FlowsFunctionSchema`s, and whose metadata is parsed out automatically from its signature and docstring). This allows the user to pass a "unified" function as a `handler` and simply omit `transition_to`/`transition_callback` without necessarily opting out of function declarations/`FlowsFunctionSchema`s.
…nified function the next node's name alongside its `NodeConfig`, to facilitate debug logging
…to `NodeConfig.functions` type definition
…ypedDict types in direct function args
…rst parameter of direct functions rather the last, so that if any of the other parameters are optional the user doesn't have to awkwardly specify a default value for `flow_manager`
…ecking validation that `flow_manager` argument is in the right place
…wResult`s from direct functions exercised in unit tests
…ctions with Gemini
… to "consolidated" functions
…ise non-required parameters (specifically, to ensure that `Optional` and not required are not the same)
…to `NodeConfig` so that we don't have to have the awkward `NamedNode`
…and `transition_callback` in favor of "consolidated" `handler` functions that return a tuple (result, next_node)
… an initial node, obviating the need for the user to call `set_node` directly; this change feels important to do now that we've added the `name` field to `NodeConfig` so that users don't end up confusingly specifying (potentially different) names in their `NodeConfig`s as in their `set_node` calls
…e()`" This reverts commit 284e464. It turns out that `set_node()` is useful outside of the function lifecycle; it's used, for example, in the warm transfer demo in an `on_participant_joined` handler (when the human agent joins)
… recommended practices
…)`, an alternative to `set_node()` that doesn't require the customer to provide a node name, since they can do so from within their node config. Hopefully users won't need to directly set nodes often, what with the introduction of: - "consolidated" functions that return the next node, eliminating the need for transition callbacks - `initialize()` taking the initial node `set_node_from_config()` is a bit clunky, but I couldn’t find a way to reuse `set_node()` without breaking API compatibility. There are ways of fudging method overloading in Python, but not without breaking keyword-argument-based invocation, it seems.
…ke 2). This time we have an alternative: `set_node_from_config()`.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Closing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes from #145 on top of the function simplification changes.