-
Notifications
You must be signed in to change notification settings - Fork 1
docs: improve README and playground md #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update the documentation and user interface for the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aims to improve the documentation by updating the README and adding a playground demo that showcases interactive D2 diagram rendering. Key changes include:
- Adding an analytics script in playground/head.html.
- Updating the Marimo app initialization in playground/d2_playground.py with enhanced configuration (injecting html_head_file and adjusting snippet settings).
- Enhancing the README with a new Playground section featuring a demo gif.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| playground/head.html | Added a deferred analytics script for tracking usage. |
| playground/d2_playground.py | Updated app initialization and tweaked snippet table configuration. |
| README.md | Added a Playground section with demo gif and updated feature list. |
Files not reviewed (1)
- js/widget.css: Language not supported
Comments suppressed due to low confidence (1)
playground/d2_playground.py:68
- [nitpick] A cell that previously rendered a markdown separator (---) has been removed. Verify if this removal aligns with the intended layout and does not inadvertently affect the UI structure.
-@app.cell(hide_code=True)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
13-13: Fix typo in notebook compatibility lineThere's a word repetition in the compatibility description.
-🧩 **Notebook Compatibility**: Works in Jupyter, Google Colab, Marimo, and other other [AnyWidget](https://github.com/manzt/anywidget)-enabled Python notebook environments +🧩 **Notebook Compatibility**: Works in Jupyter, Google Colab, Marimo, and other [AnyWidget](https://github.com/manzt/anywidget)-enabled Python notebook environments🧰 Tools
🪛 LanguageTool
[duplication] ~13-~13: Possible typo: you repeated a word.
Context: ...s in Jupyter, Google Colab, Marimo, and other other [AnyWidget](https://github.com/manzt/an...(ENGLISH_WORD_REPEAT_RULE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
assets/examples/playground.gifis excluded by!**/*.gifuv.lockis excluded by!**/*.lock
📒 Files selected for processing (4)
README.md(1 hunks)js/widget.css(1 hunks)playground/d2_playground.py(2 hunks)playground/head.html(1 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md
[duplication] ~13-~13: Possible typo: you repeated a word.
Context: ...s in Jupyter, Google Colab, Marimo, and other other [AnyWidget](https://github.com/manzt/an...
(ENGLISH_WORD_REPEAT_RULE)
🔇 Additional comments (6)
js/widget.css (1)
6-6: Good choice switching to monospace for error messages!Using a monospace font for error messages improves readability and is consistent with dev tools standards, making errors easier to scan and understand.
playground/head.html (1)
1-1: Consider adding a privacy notice for analytics trackingThe Umami analytics script is properly implemented with the
deferattribute, but you should ensure users are informed about data collection through a privacy notice or banner since this is being loaded on all playground sessions.It appears this script is tracking user interactions with the playground. Make sure this complies with privacy regulations in regions where your users might be located.
playground/d2_playground.py (2)
13-17: Good connection to the new head.html fileProperly configured the Marimo app to include the external head file, enabling the analytics tracking to work correctly.
219-221: UI improvements enhance usabilityAdding attribution for snippets provides better context for users, and reducing the page size from the default to 5 entries makes the interface more manageable.
README.md (2)
9-15: Excellent feature highlights section!The bullet points with emoji icons provide a clear and visually appealing overview of the widget's capabilities, making it much easier for users to understand the value proposition at a glance.
🧰 Tools
🪛 LanguageTool
[duplication] ~13-~13: Possible typo: you repeated a word.
Context: ...s in Jupyter, Google Colab, Marimo, and other other [AnyWidget](https://github.com/manzt/an...(ENGLISH_WORD_REPEAT_RULE)
16-21: Great addition of the playground section with demo GIFThe playground section with an animated GIF demonstration provides an excellent visual reference that immediately shows the widget in action. This makes the documentation much more engaging and helpful for new users.
Also adds small playground demo as gif.
Summary by CodeRabbit
Documentation
Style
New Features