-
Notifications
You must be signed in to change notification settings - Fork 240
EOPA build #831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EliMoshkovich
wants to merge
6
commits into
master
Choose a base branch
from
PER-12861-eopa
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+136
−1
Open
EOPA build #831
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b50d251
eopa build
EliMoshkovich 7e336d6
1.44.0 version for eopa - latest
EliMoshkovich 42dc59d
Exclude pypi when prerelease
EliMoshkovich 196ff1c
Merge branch 'refs/heads/master' into PER-12861-eopa
danyi1212 a15e0bd
Add support for building and documenting opal-client-eopa
danyi1212 b5767ce
Added expose and user under client-standalone
EliMoshkovich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: OPA Client Image Missing Port and User
The
client
Docker image is missing theEXPOSE 8181
andUSER opal
directives. These were moved to theclient-eopa
stage, which means the regular OPA client won't expose its required port 8181 and won't run as theopal
user, making it non-functional for OPA queries.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit b5767ce - restored the missing EXPOSE 8181 and USER opal directives to the client stage (lines 113-114).