-
Notifications
You must be signed in to change notification settings - Fork 240
EOPA build #831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
EOPA build #831
Conversation
✅ Deploy Preview for opal-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please create a pre-release from this branch and check that everything works correctly with @danyi1212.
Once finished let me know and I'll help with the release notes
also make sure all critical and high CVEs are removed by your upgrade of opal-client |
- Updated Makefile to include new targets for building the opal-client-eopa Docker image. - Enhanced documentation to include instructions for using the eOPA variant of the OPAL Client, with a sample Docker Compose configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
ENV OPAL_INLINE_OPA_ENABLED=true | ||
ENV OPAL_INLINE_OPA_EXEC_PATH=/opal/opa | ||
# expose opa port | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: OPA Client Image Missing Port and User
The client
Docker image is missing the EXPOSE 8181
and USER opal
directives. These were moved to the client-eopa
stage, which means the regular OPA client won't expose its required port 8181 and won't run as the opal
user, making it non-functional for OPA queries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit b5767ce - restored the missing EXPOSE 8181 and USER opal directives to the client stage (lines 113-114).
Fixes Issue
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers