Bump CI to Rustc 1.88 to support 2024 edition crates #8592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
added
the
R0-no-crate-publish-required
jsdw
changed the title
|
There is a request to update 'taplo' in 'ci-unified'. An updated image with rust 1.85 is on the way. I'll add an update with a new image tag when it's published |
jsdw
changed the title
Co-authored-by: Evgeny Snitko <evgeny@parity.io>
AndWeHaveAPlan
approved these changes
May 21, 2025
This was referenced May 23, 2025
Merged
bkchr
reviewed
May 27, 2025
jsdw
commented
Jul 4, 2025
jsdw
commented
Jul 4, 2025
jsdw
commented
Jul 4, 2025
jsdw
commented
Jul 4, 2025
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
This reverts commit 2aaabf0.
|
@bkchr are you happy with things here now? If so I think we're ready now to merge :) |
bkchr
approved these changes
Jul 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
I saw this a couple of times now so assuming some GitHub issue but fingers crossed it's intermittent enough that it'll not happen after a few retries! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
13th time lucky 😁 |
sigurpol
pushed a commit
that referenced
this pull request
Jul 8, 2025
As one example, this allows us to use the latest version of Subxt: 0.42. Also if-let chains :) Main changes: - Update CI image - Remove `forklift` from Build step in `check-revive-stable-uapi-polkavm`; it seemed to [cause an error](https://github.com/paritytech/polkadot-sdk/actions/runs/16004536662/job/45148002314?pr=8592). Perhaps we can open an issue for this to fix/try again after this merges. - Bump `polkavm` deps to 0.26 to avoid [this error](https://github.com/paritytech/polkadot-sdk/actions/runs/16004991577/job/45150325849?pr=8592#step:5:1967) (thanks @koute!) - Add `result_large_err` clippy to avoid a bunch of clippy warnings about a 176 byte error (again, we could fix this later more properly). - Clippy fixes (mainly inlining args into `format!`s where possible), remove one `#[no_mangle]` on a `#[panic_hook]` and a few other misc automatic fixes. - `#[allow(clippy::useless_conversion)]` in frame macro to avoid the generated `.map(Into::into).map_err(Into::into)` code causing an issue when not necessary (it is sometimes; depends on the return type in pallet calls) - UI test updates As a side note, I haven't added a `prdoc` since I'm not making any breaking changes (despite touching a bunch of pallets), just clippy/fmt type things. Please comment if this isn't ok! Also, thankyou @bkchr for the wasmtime update PR which fixed a blocker here! --------- Co-authored-by: Evgeny Snitko <evgeny@parity.io> Co-authored-by: Bastian Köcher <git@kchr.de>
jsdw
added
the
A4-backport-stable2506
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-8592-to-stable2506
git worktree add --checkout .worktree/backport-8592-to-stable2506 backport-8592-to-stable2506
cd .worktree/backport-8592-to-stable2506
git reset --hard HEAD^
git cherry-pick -x 771c9988e2a636a150d97c10e3122af8068d1687
git push --force-with-lease |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As one example, this allows us to use the latest version of Subxt: 0.42. Also if-let chains :)
Main changes:
forkliftfrom Build step incheck-revive-stable-uapi-polkavm; it seemed to cause an error. Perhaps we can open an issue for this to fix/try again after this merges.polkavmdeps to 0.26 to avoid this error (thanks @koute!)result_large_errclippy to avoid a bunch of clippy warnings about a 176 byte error (again, we could fix this later more properly).format!s where possible), remove one#[no_mangle]on a#[panic_hook]and a few other misc automatic fixes.#[allow(clippy::useless_conversion)]in frame macro to avoid the generated.map(Into::into).map_err(Into::into)code causing an issue when not necessary (it is sometimes; depends on the return type in pallet calls)As a side note, I haven't added a
prdocsince I'm not making any breaking changes (despite touching a bunch of pallets), just clippy/fmt type things. Please comment if this isn't ok!Also, thankyou @bkchr for the wasmtime update PR which fixed a blocker here!