Docs - Starlight Refactoring #929
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for a Starlight upgrade, I discovered that there were several opportunities to simplify the custom components and avoid reimplementing built-in component logic so that long term maintenance is easier, and it benefits from future enhancements.
Hero
component because it did not seem to deviate from the built-in component.Footer
component to use the built-in component.Sidebar
component with a version that leverages the built-in component, and was able to remove the redundantSidebarSubList
component.Header
component in favor of simply overriding theSearch
component. (This maintains the Mobile menu.)TableOfContents
component to use the built-in component.There may be some slight cosmetic differences, but hopefully you will agree that this is easier to maintain and sets the project up to benefit from future enhancements, such as the
SidebarPersister
.