Skip to content

Docs - Starlight Refactoring #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

awhitford
Copy link
Contributor

In preparation for a Starlight upgrade, I discovered that there were several opportunities to simplify the custom components and avoid reimplementing built-in component logic so that long term maintenance is easier, and it benefits from future enhancements.

  • Removed the Hero component because it did not seem to deviate from the built-in component.
  • Revised the Footer component to use the built-in component.
  • Replaced the custom Sidebar component with a version that leverages the built-in component, and was able to remove the redundant SidebarSubList component.
  • Removed the Header component in favor of simply overriding the Search component. (This maintains the Mobile menu.)
  • Revised the TableOfContents component to use the built-in component.

There may be some slight cosmetic differences, but hopefully you will agree that this is easier to maintain and sets the project up to benefit from future enhancements, such as the SidebarPersister.

Copy link

vercel bot commented Apr 28, 2025

@awhitford is attempting to deploy a commit to the OramaSearch Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Apr 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
orama-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2025 11:58am

@awhitford
Copy link
Contributor Author

@micheleriva Please let me know if you have any questions or concerns about this PR. Once merged, I will revisit the Astro and Starlight upgrade, but this will make things easier.

@Saif-Shines
Copy link

I'm imaging this plugin will:

  • Allow my to declare configuration about Orama
  • Key in credentials from Orama Cloud
  • The Search, Header or necessary UI components are automatically overriden.

Is that right? @awhitford ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants