[GR-14806] Update specs.

PullRequest: truffleruby/2690

Author: eregon

spec/mspec/.rspec

@@ -0,0 +1 @@
+--color

spec/mspec/lib/mspec/helpers/ruby_exe.rb

@@ -15,8 +15,10 @@
 #
 #   `#{RUBY_EXE} 'path/to/some/file.rb'`
 #
-# The ruby_exe helper also accepts an options hash with three
-# keys: :options, :args and :env. For example:
+# The ruby_exe helper also accepts an options hash with four
+# keys: :options, :args :env and :exception.
+#
+# For example:
 #
 #   ruby_exe('file.rb', :options => "-w",
 #                       :args => "arg1 arg2",
@@ -28,6 +30,9 @@
 #
 # with access to ENV["FOO"] with value "bar".
 #
+# When `exception: false` and Ruby command fails then exception will not be
+# raised.
+#
 # If +nil+ is passed for the first argument, the command line
 # will be built only from the options hash.
 #
@@ -52,6 +57,8 @@
 # (with -T on the command line or in the config with set :flags)
 # will be appended to RUBY_EXE so that the interpreter
 # is always called with those flags.
+#
+# Failure of a Ruby command leads to raising exception by default.
 
 def ruby_exe_options(option)
   case option
@@ -128,9 +135,19 @@ def ruby_exe(code = :not_given, opts = {})
     code = tmpfile
   end
 
+  expected_exit_status = opts.fetch(:exit_status, 0)
+
   begin
     platform_is_not :opal do
-      `#{ruby_cmd(code, opts)}`
+      command = ruby_cmd(code, opts)
+      output = `#{command}`
+
+      last_status = Process.last_status
+      if last_status.exitstatus != expected_exit_status
+        raise "Expected exit status is #{expected_exit_status.inspect} but actual is #{last_status.exitstatus.inspect} for command ruby_exe(#{command.inspect})"
+      end
+
+      output
     end
   ensure
     saved_env.each { |key, value| ENV[key] = value }

spec/mspec/lib/mspec/matchers/match_yaml.rb

@@ -30,7 +30,11 @@ def clean_yaml(yaml)
   def valid_yaml?(obj)
     require 'yaml'
     begin
-      YAML.load(obj)
+      if YAML.respond_to?(:unsafe_load)
+        YAML.unsafe_load(obj)
+      else
+        YAML.load(obj)
+      end
     rescue
       false
     else

spec/mspec/spec/helpers/ruby_exe_spec.rb

@@ -146,6 +146,18 @@ class RubyExeSpecs
 
     @script = RubyExeSpecs.new
     allow(@script).to receive(:`)
+
+    status_successful = double(Process::Status,  exitstatus: 0)
+    allow(Process).to receive(:last_status).and_return(status_successful)
+  end
+
+  it "returns command STDOUT when given command" do
+    code = "code"
+    options = {}
+    output = "output"
+    allow(@script).to receive(:`).and_return(output)
+
+    expect(@script.ruby_exe(code, options)).to eq output
   end
 
   it "returns an Array containing the interpreter executable and flags when given no arguments" do
@@ -160,6 +172,30 @@ class RubyExeSpecs
     @script.ruby_exe(code, options)
   end
 
+  it "raises exception when command exit status is not successful" do
+    code = "code"
+    options = {}
+
+    status_failed = double(Process::Status, exitstatus: 4)
+    allow(Process).to receive(:last_status).and_return(status_failed)
+
+    expect {
+      @script.ruby_exe(code, options)
+    }.to raise_error(%r{Expected exit status is 0 but actual is 4 for command ruby_exe\(.+\)})
+  end
+
+  it "shows in the exception message if exitstatus is nil (e.g., signal)" do
+    code = "code"
+    options = {}
+
+    status_failed = double(Process::Status, exitstatus: nil)
+    allow(Process).to receive(:last_status).and_return(status_failed)
+
+    expect {
+      @script.ruby_exe(code, options)
+    }.to raise_error(%r{Expected exit status is 0 but actual is nil for command ruby_exe\(.+\)})
+  end
+
   describe "with :dir option" do
     it "is deprecated" do
       expect {
@@ -197,4 +233,24 @@ class RubyExeSpecs
       end.to raise_error(Exception)
     end
   end
+
+  describe "with :exit_status option" do
+    before do
+      status_failed = double(Process::Status, exitstatus: 4)
+      allow(Process).to receive(:last_status).and_return(status_failed)
+    end
+
+    it "raises exception when command ends with not expected status" do
+      expect {
+        @script.ruby_exe("path", exit_status: 1)
+      }.to raise_error(%r{Expected exit status is 1 but actual is 4 for command ruby_exe\(.+\)})
+    end
+
+    it "does not raise exception when command ends with expected status" do
+      output = "output"
+      allow(@script).to receive(:`).and_return(output)
+
+      expect(@script.ruby_exe("path", exit_status: 4)).to eq output
+    end
+  end
 end

spec/ruby/README.md

@@ -30,7 +30,7 @@ ruby/spec is known to be tested in these implementations for every commit:
 * [Opal](https://github.com/opal/opal/tree/master/spec)
 
 ruby/spec describes the behavior of Ruby 2.5 and more recent Ruby versions.
-More precisely, every latest stable MRI release should [pass](https://travis-ci.org/ruby/spec) all specs of ruby/spec (2.5.x, 2.6.x, 2.7.x, etc), and those are tested in TravisCI.
+More precisely, every latest stable MRI release should [pass](https://github.com/ruby/spec/actions/workflows/ci.yml) all specs of ruby/spec (2.5.x, 2.6.x, 2.7.x, etc), and those are tested in CI.
 
 ### Synchronization with Ruby Implementations
 

spec/ruby/command_line/dash_encoding_spec.rb

@@ -25,6 +25,12 @@
   end
 
   it "does not accept a third encoding" do
-    ruby_exe(@test_string, options: "--disable-gems --encoding big5:#{@enc2}:utf-32le", args: "2>&1").should =~ /extra argument for --encoding: utf-32le/
+    options = {
+      options: "--disable-gems --encoding big5:#{@enc2}:utf-32le",
+      args: "2>&1",
+      exit_status: 1
+    }
+
+    ruby_exe(@test_string, options).should =~ /extra argument for --encoding: utf-32le/
   end
 end

spec/ruby/command_line/dash_r_spec.rb

@@ -13,7 +13,7 @@
   end
 
   it "requires the file before parsing the main script" do
-    out = ruby_exe(fixture(__FILE__, "bad_syntax.rb"), options: "-r #{@test_file}", args: "2>&1")
+    out = ruby_exe(fixture(__FILE__, "bad_syntax.rb"), options: "-r #{@test_file}", args: "2>&1", exit_status: 1)
     $?.should_not.success?
     out.should include("REQUIRED")
     out.should include("syntax error")

spec/ruby/command_line/dash_upper_e_spec.rb

@@ -31,6 +31,7 @@
   it "raises a RuntimeError if used with -U" do
     ruby_exe("p 1",
              options: '-Eascii:ascii -U',
-             args: '2>&1').should =~ /RuntimeError/
+             args: '2>&1',
+             exit_status: 1).should =~ /RuntimeError/
   end
 end

spec/ruby/command_line/dash_upper_s_spec.rb

@@ -21,7 +21,7 @@
     end
 
     it "runs launcher found in PATH and sets the exit status to 1 if it fails" do
-      result = ruby_exe(nil, options: '-S dash_s_fail', env: { 'PATH' => @path }, args: '2>&1')
+      result = ruby_exe(nil, options: '-S dash_s_fail', env: { 'PATH' => @path }, args: '2>&1', exit_status: 1)
       result.should =~ /\bdie\b/
       $?.exitstatus.should == 1
     end

spec/ruby/command_line/dash_upper_u_spec.rb

@@ -32,12 +32,14 @@
   it "raises a RuntimeError if used with -Eext:int" do
     ruby_exe("p 1",
              options: '-U -Eascii:ascii',
-             args: '2>&1').should =~ /RuntimeError/
+             args: '2>&1',
+             exit_status: 1).should =~ /RuntimeError/
   end
 
   it "raises a RuntimeError if used with -E:int" do
     ruby_exe("p 1",
              options: '-U -E:ascii',
-             args: '2>&1').should =~ /RuntimeError/
+             args: '2>&1',
+             exit_status: 1).should =~ /RuntimeError/
   end
 end