[GR-31842] Fix delegation in open-uri

PullRequest: truffleruby/2688

Author: eregon

lib/mri/open-uri.rb

@@ -10,18 +10,22 @@ class << self
     alias open_uri_original_open open # :nodoc:
   end
 
-  def open(name, *rest, **kw, &block) # :nodoc:
+  def open(name, *rest, &block) # :nodoc:
     if (name.respond_to?(:open) && !name.respond_to?(:to_path)) ||
        (name.respond_to?(:to_str) &&
         %r{\A[A-Za-z][A-Za-z0-9+\-\.]*://} =~ name &&
         (uri = URI.parse(name)).respond_to?(:open))
       warn('calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open', uplevel: 1)
-      URI.open(name, *rest, **kw, &block)
+      URI.open(name, *rest, &block)
     else
-      open_uri_original_open(name, *rest, **kw, &block)
+      open_uri_original_open(name, *rest, &block)
     end
   end
   module_function :open
+  ruby2_keywords :open
+  class << self
+    ruby2_keywords :open
+  end
 end
 
 module URI

spec/ruby/core/kernel/open_spec.rb

@@ -2,7 +2,6 @@
 require_relative 'fixtures/classes'
 
 describe "Kernel#open" do
-
   before :each do
     @name = tmp("kernel_open.txt")
     @content = "This is a test"
@@ -137,6 +136,18 @@
   it "accepts nil for mode and permission" do
     open(@name, nil, nil) { |f| f.gets }.should == @content
   end
+
+  ruby_version_is ""..."3.0" do
+    it "works correctly when redefined by open-uri" do
+      code = <<~RUBY
+      require 'open-uri'
+      obj = Object.new
+      def obj.to_open; self; end
+      p open(obj) == obj
+      RUBY
+      ruby_exe(code, args: "2>&1").should == "true\n"
+    end
+  end
 end
 
 describe "Kernel.open" do

spec/tags/core/kernel/open_tags.txt

@@ -0,0 +1 @@
+slow:Kernel#open works correctly when redefined by open-uri