Specify the exit_status for ruby_exe when it is not 0

* Required by recent MSpec changes.

Author: eregon

spec/truffle/java_exception_spec.rb

@@ -11,7 +11,7 @@
 describe "Internal errors reaching the top level" do
   it "show both the Java stacktrace and Ruby backtrace" do
     file = fixture(__FILE__, 'throw_java_exception.rb')
-    out = ruby_exe(file, args: "2>&1")
+    out = ruby_exe(file, args: "2>&1", exit_status: 1)
     out = out.gsub(/\.java:\d+/, '.java:LINE')
     out.should.include? <<-EOS
 truffleruby: an internal exception escaped out of the interpreter,
@@ -29,7 +29,7 @@
   end
 
   it "show the cause" do
-    out = ruby_exe("Truffle::Debug.throw_java_exception_with_cause 'message'", args: "2>&1")
+    out = ruby_exe("Truffle::Debug.throw_java_exception_with_cause 'message'", args: "2>&1", exit_status: 1)
     message = out.gsub(/:\d+/, ':LINE')
 
     message.should.include? <<-EOS
@@ -47,7 +47,7 @@
     end
     sleep
     RUBY
-    out = ruby_exe(code, args: "2>&1")
+    out = ruby_exe(code, args: "2>&1", exit_status: 1)
     $?.exitstatus.should == 1
     out.should.include? "```\nRuby Thread"
     out.should.include? "terminated with internal error: (java.lang.RuntimeException)"

spec/truffle/launcher_spec.rb

@@ -274,11 +274,11 @@ def should_print_full_java_command(options, env: {})
   end
 
   it "prints an error for an unknown option" do
-    out = ruby_exe(nil, options: "--unknown=value", args: "2>&1")
+    out = ruby_exe(nil, options: "--unknown=value", args: "2>&1", exit_status: 2)
     $?.success?.should == false
     out.should include("invalid option --unknown=value")
 
-    out = ruby_exe(nil, options: "--ruby.unknown=value", args: "2>&1")
+    out = ruby_exe(nil, options: "--ruby.unknown=value", args: "2>&1", exit_status: 2)
     $?.success?.should == false
     out.should include("invalid option --ruby.unknown=value")
   end
@@ -380,7 +380,7 @@ def should_print_full_java_command(options, env: {})
   end
 
   it "does not print a Java backtrace for an -S file that's not found" do
-    out = ruby_exe(nil, options: "-S does_not_exist", args: "2>&1")
+    out = ruby_exe(nil, options: "-S does_not_exist", args: "2>&1", exit_status: 1)
     $?.success?.should == false
     out.should include('truffleruby: No such file or directory -- does_not_exist (LoadError)')
     out.should_not include('boot.rb')

spec/truffle/options/cexts_spec.rb

@@ -18,6 +18,6 @@
   end
 
   it "when disabled cannot use parts of the stdlib that use C extensions" do
-    ruby_exe("require 'yaml'; p YAML.load('--- foo')", options: "--experimental-options --cexts=false", args: "2>&1").should =~ /disabled/
+    ruby_exe("require 'yaml'; p YAML.load('--- foo')", options: "--experimental-options --cexts=false", args: "2>&1", exit_status: 1).should.include?("cannot load as C extensions are disabled")
   end
 end

spec/truffle/options/parsing_spec.rb

@@ -9,9 +9,7 @@
 require_relative '../../ruby/spec_helper'
 
 describe "Options" do
-
   describe "can correctly parse" do
-
     it "booleans" do
       ruby_exe("p Truffle::Boot.get_option('frozen-string-literals')").should_not == "true\n"
       ruby_exe("p Truffle::Boot.get_option('frozen-string-literals')", options: "--experimental-options --frozen-string-literals=true").should == "true\n"
@@ -39,23 +37,19 @@
       ruby_exe("p Truffle::Boot.get_option('load-paths')", options: "--load-paths=a,b,c").should == "[\"a\", \"b\", \"c\"]\n"
       ruby_exe("p Truffle::Boot.get_option('load-paths')", options: "--load-paths=a\\\\,b,c").should == "[\"a,b\", \"c\"]\n"
     end
-
   end
 
   describe "handles parsing errors with" do
-
     it "booleans" do
-      ruby_exe("14", options: "--frozen-string-literals=foo", args: "2>&1").should include("Invalid boolean option value 'foo'")
+      ruby_exe("14", options: "--frozen-string-literals=foo", args: "2>&1", exit_status: 1).should include("Invalid boolean option value 'foo'")
     end
 
     it "integers" do
-      ruby_exe("14", options: "--default-cache=foo", args: "2>&1").should include("Invalid argument --default-cache=foo specified")
+      ruby_exe("14", options: "--default-cache=foo", args: "2>&1", exit_status: 1).should include("Invalid argument --default-cache=foo specified")
     end
 
     it "enum values" do
-      ruby_exe("14", options: "--verbose=foo", args: "2>&1").should include("Invalid argument --verbose=foo specified. No enum constant org.truffleruby.shared.options.Verbosity.FOO'")
+      ruby_exe("14", options: "--verbose=foo", args: "2>&1", exit_status: 1).should include("Invalid argument --verbose=foo specified. No enum constant org.truffleruby.shared.options.Verbosity.FOO'")
     end
-
   end
-
 end