Skip to content

fix: duplicate offer being created on issuers side while negotiating offer as a holder #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 5, 2024
Merged

fix: duplicate offer being created on issuers side while negotiating offer as a holder #2023

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d5975b6
fix: duplicate offer being created on issuers side while negotiating …
GHkrishna Aug 28, 2024
3a8f8f5
fix: negotiating Offer by asserting connectionId and association
GHkrishna Sep 3, 2024
8dd2310
fix: remove duplicate assertion
GHkrishna Sep 3, 2024
0a45441
chore: fix sequence for connection association
GHkrishna Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/core/src/modules/credentials/protocol/v2/V2CredentialProtocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,6 @@ export class V2CredentialProtocol<CFs extends CredentialFormatService[] = Creden
let credentialRecord = await this.findByProperties(messageContext.agentContext, {
threadId: proposalMessage.threadId,
role: CredentialRole.Issuer,
connectionId: connection?.id,
})

const formatServices = this.getFormatServicesFromMessage(proposalMessage.formats)
Expand Down Expand Up @@ -207,6 +206,15 @@ export class V2CredentialProtocol<CFs extends CredentialFormatService[] = Creden
expectedConnectionId: credentialRecord.connectionId,
})

// This makes sure that the sender of the incoming message is authorized to do so.
if (!credentialRecord?.connectionId) {
await connectionService.matchIncomingMessageToRequestMessageInOutOfBandExchange(messageContext, {
expectedConnectionId: credentialRecord?.connectionId,
})

credentialRecord.connectionId = connection?.id
}

await this.credentialFormatCoordinator.processProposal(messageContext.agentContext, {
credentialRecord,
formatServices,
Expand Down
Loading