Skip to content

Conversation

GHkrishna
Copy link
Contributor

What

How

  • Initially during processing proposal in cases where an OOB credential is being offered.
  • If holder, accepts OOB invitation and negotiates the offer, the connection details are appended on the holders side.
  • But for issuer we are unable to update the credential record with the connection details.
  • Hence, the issuer considers this credential proposal as a new flow and creates a new credential record with connection details. This causes the flow to break further in the processing when two records against a single threadId are found

…offer

Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Copy link

changeset-bot bot commented Sep 2, 2024

⚠️ No Changeset found

Latest commit: 0a45441

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TimoGlastra
Copy link
Contributor

Previously we haven't supported proposals for connectionless exchanges. We probably need some additional checks to ensure the exchange can't be hijacked by another connection. You can look at the other methods. And we need to set the connection id after fetching if it's available

Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
@GHkrishna GHkrishna marked this pull request as draft September 3, 2024 06:30
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
@GHkrishna
Copy link
Contributor Author

@TimoGlastra is this the right approach to associate the connectionId once we get the credentialRecord

@GHkrishna GHkrishna marked this pull request as ready for review September 3, 2024 09:58
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TimoGlastra TimoGlastra enabled auto-merge (squash) September 5, 2024 11:18
@TimoGlastra TimoGlastra merged commit 5ddd37a into openwallet-foundation:main Sep 5, 2024
13 checks passed
@GHkrishna GHkrishna deleted the fix/negotiate-offer branch September 5, 2024 11:32
genaris pushed a commit to genaris/credo-ts that referenced this pull request Oct 9, 2025
…offer as a holder (openwallet-foundation#2023)

Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate credential record as Issuer when OOB offer and negotiateOffer as Holder

2 participants