Skip to content

CNV-61371 - Added AAQ metrics #96517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: enterprise-4.20
Choose a base branch
from
+11 −0
Open

CNV-61371 - Added AAQ metrics #96517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions modules/virt-querying-metrics.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,3 +141,14 @@ topk(3, sum by (name, namespace) (rate(kubevirt_vmi_memory_swap_in_traffic_bytes
====
Memory swapping indicates that the virtual machine is under memory pressure. Increasing the memory allocation of the virtual machine can mitigate this issue.
====

[id=virt-promql-AAQ-metrics_context]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[id=virt-promql-AAQ-metrics_context]
[id="virt-promql-AAQ-metrics_{context}"]

== Monitoring AAQ operator metrics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
== Monitoring AAQ operator metrics
== AAQ Operator metrics


The following metrics are exposed by the Application Aware Quota (AAQ) controller for monitoring resource quotas:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following metrics are exposed by the Application Aware Quota (AAQ) controller for monitoring resource quotas:
The following metrics are exposed by the Application-Aware Quota (AAQ) Operator controller for monitoring resource quotas:


.`kube_application_aware_resourcequota`::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.`kube_application_aware_resourcequota`::
`kube_application_aware_resourcequota`::

Returns the current usage of application-aware resource quotas. Type: Gauge.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it returns both hard limit and current usage of resources
I guess it could be like ""Returns the hard limit and current usage of application-aware resource quotas..."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit vague. I would suggest changing it to something like this. Please get it reviewed by an SME to ensure technical accuracy.

Suggested change
Returns the current usage of application-aware resource quotas. Type: Gauge.
Returns the current quota usage and the CPU and memory limits enforced by the AAQ Operator resources. Type: Gauge.


.`kube_application_aware_resourcequota_creation_timestamp`::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.`kube_application_aware_resourcequota_creation_timestamp`::
`kube_application_aware_resourcequota_creation_timestamp`::

Returns the Unix timestamp of the application-aware resource quota creation. Type: Gauge.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the timestamp of when an AAQ Operator resource (ApplicationAwareResourceQuota or ApplicationAwareClusterResourceQuota is created? If so, my suggestion would be reword it to something like this:

Suggested change
Returns the Unix timestamp of the application-aware resource quota creation. Type: Gauge.
Returns the time, in UNIX timestamp format, when the AAQ Operator resource is created. Type: Gauge.