CNV-61371 - Added AAQ metrics #96517
Open
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/S
Vaishali-gif-rh
force-pushed
the
CNV-61371
branch
from
31d565a to
26aaced
Compare
|
@Vaishali-gif-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
akri3i
suggested changes
Jul 23, 2025
| The following metrics are exposed by the Application Aware Quota (AAQ) controller for monitoring resource quotas: | ||
|
|
||
| .`kube_application_aware_resourcequota`:: | ||
| Returns the current usage of application-aware resource quotas. Type: Gauge. |
There was a problem hiding this comment.
it returns both hard limit and current usage of resources
I guess it could be like ""Returns the hard limit and current usage of application-aware resource quotas..."
sjhala-ccs
reviewed
Jul 23, 2025
| @@ -141,3 +141,14 @@ topk(3, sum by (name, namespace) (rate(kubevirt_vmi_memory_swap_in_traffic_bytes | |||
| ==== | |||
| Memory swapping indicates that the virtual machine is under memory pressure. Increasing the memory allocation of the virtual machine can mitigate this issue. | |||
| ==== | |||
|
|
|||
| [id=virt-promql-AAQ-metrics_context] | |||
There was a problem hiding this comment.
Suggested change
| [id=virt-promql-AAQ-metrics_context] | |
| [id="virt-promql-AAQ-metrics_{context}"] |
|
|
||
| The following metrics are exposed by the Application Aware Quota (AAQ) controller for monitoring resource quotas: | ||
|
|
||
| .`kube_application_aware_resourcequota`:: |
There was a problem hiding this comment.
Suggested change
| .`kube_application_aware_resourcequota`:: | |
| `kube_application_aware_resourcequota`:: |
| .`kube_application_aware_resourcequota`:: | ||
| Returns the current usage of application-aware resource quotas. Type: Gauge. | ||
|
|
||
| .`kube_application_aware_resourcequota_creation_timestamp`:: |
There was a problem hiding this comment.
Suggested change
| .`kube_application_aware_resourcequota_creation_timestamp`:: | |
| `kube_application_aware_resourcequota_creation_timestamp`:: |
| @@ -141,3 +141,14 @@ topk(3, sum by (name, namespace) (rate(kubevirt_vmi_memory_swap_in_traffic_bytes | |||
| ==== | |||
| Memory swapping indicates that the virtual machine is under memory pressure. Increasing the memory allocation of the virtual machine can mitigate this issue. | |||
| ==== | |||
|
|
|||
| [id=virt-promql-AAQ-metrics_context] | |||
| == Monitoring AAQ operator metrics | |||
There was a problem hiding this comment.
Suggested change
| == Monitoring AAQ operator metrics | |
| == AAQ Operator metrics |
| [id=virt-promql-AAQ-metrics_context] | ||
| == Monitoring AAQ operator metrics | ||
|
|
||
| The following metrics are exposed by the Application Aware Quota (AAQ) controller for monitoring resource quotas: |
There was a problem hiding this comment.
Suggested change
| The following metrics are exposed by the Application Aware Quota (AAQ) controller for monitoring resource quotas: | |
| The following metrics are exposed by the Application-Aware Quota (AAQ) Operator controller for monitoring resource quotas: |
| Returns the current usage of application-aware resource quotas. Type: Gauge. | ||
|
|
||
| .`kube_application_aware_resourcequota_creation_timestamp`:: | ||
| Returns the Unix timestamp of the application-aware resource quota creation. Type: Gauge. |
There was a problem hiding this comment.
Is this the timestamp of when an AAQ Operator resource (ApplicationAwareResourceQuota or ApplicationAwareClusterResourceQuota is created? If so, my suggestion would be reword it to something like this:
Suggested change
| Returns the Unix timestamp of the application-aware resource quota creation. Type: Gauge. | |
| Returns the time, in UNIX timestamp format, when the AAQ Operator resource is created. Type: Gauge. |
| The following metrics are exposed by the Application Aware Quota (AAQ) controller for monitoring resource quotas: | ||
|
|
||
| .`kube_application_aware_resourcequota`:: | ||
| Returns the current usage of application-aware resource quotas. Type: Gauge. |
There was a problem hiding this comment.
This is a bit vague. I would suggest changing it to something like this. Please get it reviewed by an SME to ensure technical accuracy.
Suggested change
| Returns the current usage of application-aware resource quotas. Type: Gauge. | |
| Returns the current quota usage and the CPU and memory limits enforced by the AAQ Operator resources. Type: Gauge. |
sjhala-ccs
added
the
peer-review-done
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version(s):
4.20
Issue:
https://issues.redhat.com/browse/CNV-61371
Link to docs preview:
QE review:
Additional information: