Skip to content

[OCPBUGS-52991] : Correcting the typo for the path in section "3.2.4 Updating mirror registry for Red Hat OpenShift from a local host" #90130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[OCPBUGS-52991] : Correcting the typo for the path in section "3.2.4 Updating mirror registry for Red Hat OpenShift from a local host" #90130

wants to merge 1 commit into from

Conversation

gagankrmahto
Copy link

@gagankrmahto gagankrmahto commented Mar 12, 2025 •
edited
Loading

Correcting the typo for the path in section "3.2.4. Updating mirror registry for Red Hat OpenShift from a local host"

Version(s):

4.13+

Issue:

https://issues.redhat.com/browse/OCPBUGS-52991

Link to docs preview:

https://90130--ocpdocs-pr.netlify.app/openshift-enterprise/latest/disconnected/mirroring/installing-mirroring-creating-registry.html

QE review:

  • QE has approved this change.

Additional information:

@gagankrmahto
[OCPBUGS-52991] : Correcting the typo for the path in section "3.2.4.…
afdcd27 
… Updating mirror registry for Red Hat OpenShift from a local host"

Correcting the typo for the path in section "3.2.4. Updating mirror registry for Red Hat OpenShift from a local host"
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 12, 2025
@ocpdocs-previewbot
Copy link

🤖 Wed Mar 12 02:36:30 - Prow CI generated the docs preview:

https://90130--ocpdocs-pr.netlify.app/openshift-enterprise/latest/disconnected/mirroring/installing-mirroring-creating-registry.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 12, 2025

@gagankrmahto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gagankrmahto
Copy link
Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 12, 2025
@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 12, 2025
@xenolinux xenolinux added this to the Continuous Release milestone Mar 12, 2025
@xenolinux xenolinux mentioned this pull request Mar 12, 2025
Open
1 task
xenolinux
xenolinux reviewed Mar 12, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

A general suggestion: I see that you have another PR that addresses the same change in another file. For future instances, you can include all of your changes in a single PR only.

We also need a QE approval (as the /lgtm comment on the PR) but because this is a typo-related change. You can skip that for this PR.

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 12, 2025
@gagankrmahto
Copy link
Author

Thank you , I will make sure to create a single PR from next time

@gagankrmahto
Copy link
Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 12, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 merge-review-needed Signifies that the merge review team needs to review this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Mar 12, 2025
@mburke5678 mburke5678 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 12, 2025
@kalexand-rh
Copy link
Contributor

This has been corrected on #90933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenolinux xenolinux xenolinux left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 ok-to-merge peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
5 participants
@gagankrmahto @ocpdocs-previewbot @kalexand-rh @xenolinux @mburke5678