-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[OCPBUGS-52991] : Correcting the typo for the path in section "3.2.6. Updating mirror registry for Red Hat OpenShift from a remote host" #90129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Correcting the typo for the path, /$HOME/quay-instal/quay-postgres-backup/ It should be /$HOME/quay-install/quay-postgres-backup/
🤖 Wed Mar 12 02:20:14 - Prow CI generated the docs preview: |
@gagankrmahto: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
A general suggestion: I see that you have another PR that addresses the same change in another file. For future instances, you can include all of your changes in a single PR only.
We also need a QE approval (as the /lgtm
comment on the PR) but because this is a typo-related change. You can skip that for this PR.
Thank you , I will make sure to create a single PR from next time |
/label merge-review-needed |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
The This is because your PR targets the If the update in your PR does NOT apply to version 4.20 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
Correcting the typo for the path,
/$HOME/quay-instal/quay-postgres-backup/
It should be
/$HOME/quay-install/quay-postgres-backup/
Version(s):
4.13+
Issue:
OCPBUGS-52991
Link to docs preview:
https://90129--ocpdocs-pr.netlify.app/openshift-enterprise/latest/disconnected/mirroring/installing-mirroring-creating-registry.html
QE review:
Additional information: