fix the tutorial in AIConnectorHelper when fetching domain_url #3852
+29
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zhangxunmt
requested review from
b4sjoo,
dhrubo-os,
mingshl,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
austintlee,
HenryL27 and
xinyual
as code owners
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
| " domain_arn = domain_info['ARN']\n", | ||
| "\n", | ||
| " # Check if domain has VPC endpoints\n", | ||
| " if 'Endpoints' in domain_info:\n", |
There was a problem hiding this comment.
I used this logic to check for VPC endpoint in the connector CLI. Maybe you can try this out since this is simpler? (ref)
domain_url = (
domain_info.get("Endpoint") or domain_info["Endpoints"]["vpc"]
)
There was a problem hiding this comment.
If Endpoints or vpc does not exist, it would throw KeyError if key doesn't exist so you need to run this tutorial from begin.
There was a problem hiding this comment.
I see, that makes sense.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3852 +/- ##
=========================================
Coverage 78.01% 78.02%
- Complexity 7336 7337 +1
=========================================
Files 656 656
Lines 33074 33074
Branches 3708 3708
=========================================
+ Hits 25804 25805 +1
Misses 5683 5683
+ Partials 1587 1586 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
previously approved these changes
May 21, 2025
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Signed-off-by: Xun Zhang <xunzh@amazon.com>
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
previously approved these changes
May 21, 2025
|
Thanks for the fix. Can you also fix this https://github.com/opensearch-project/ml-commons/blob/main/docs/tutorials/aws/DeepSeek_demo_notebook_for_RAG.ipynb |
Signed-off-by: Xun Zhang <xunzh@amazon.com>
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the error when calling describe_elasticsearch_domain to get domain_url for VPC domains. For VPC domains, the returned Endpoints is a Map rather than a String.
https://docs.aws.amazon.com/cli/latest/reference/es/describe-elasticsearch-domain.html
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.