Skip to content

Improvements to workflows #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 22, 2025
Merged

Improvements to workflows #20

merged 9 commits into from
Mar 22, 2025

Conversation

rcannood
Copy link
Member

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@LouisK92
Copy link
Contributor

I added the metadata, e.g. the urls to both datasets (spatial and sc), which then has the form dataset_url=url_spatial;url_sc.
Was thinking maybe we want to always use two entries instead of one, e.g. dataset_url_ist, dataset_url_sc instead of dataset_url etc. - what do you think?
For now not super important - but for later maybe useful add-on?

@rcannood
Copy link
Member Author

Using separate dataset_url_ist and dataset_url_sc would definitely break things downstream. However, turning it into a list would be possible. Would thos work as well?

@LouisK92
Copy link
Contributor

sounds like a good solution!

@rcannood rcannood marked this pull request as ready for review March 22, 2025 06:50
@rcannood
Copy link
Member Author

Merging it so I can give this a shot, but please let me know if you have any feedback! @LouisK92

@rcannood rcannood merged commit ac0c0c0 into main Mar 22, 2025
3 checks passed
@rcannood rcannood deleted the improvements branch March 22, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants