Skip to content

Add clustermap #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add clustermap #13

wants to merge 6 commits into from

Conversation

habibrehman2002
Copy link

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @habibrehman2002 ! Thanks for contributing!

It seems like one of the tests is failing because it can't find ClusterMap.

Probably something is going wrong with the installation.

Could you run viash test src/methods_transcript_assignment/clustermap_transcript_assignment/config.vsh.yaml and fix any issues that show up?

Thanks!

@habibrehman2002
Copy link
Author

Hello @habibrehman2002 ! Thanks for contributing!

It seems like one of the tests is failing because it can't find ClusterMap.

Probably something is going wrong with the installation.

Could you run viash test src/methods_transcript_assignment/clustermap_transcript_assignment/config.vsh.yaml and fix any issues that show up?

Thanks!

Hi @rcannood , I've been running into a lot of issues installing ClusterMap using docker, even though it works fine when using the native environment. It seems like ClusterMap gets cloned from git (and installed since you can see the version number), but for some reason is not able to be loaded/imported? I've discussed it with @LouisK92 and we might try creating a custom docker container for it and see if that works (rather than installing using the config.vsh.yaml functionality).

@LouisK92 LouisK92 marked this pull request as ready for review April 2, 2025 11:08
@LouisK92
Copy link
Contributor

LouisK92 commented Apr 3, 2025

@rcannood How can I adjust the memory for the gh action viash tests? I think the current test failure comes from a memory error (if I understood correctly) - mem seems to be set to 14GB

Locally the test runs through

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants