Skip to content

Add scPRINT method #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 26, 2024
Merged

Add scPRINT method #13

merged 15 commits into from
Nov 26, 2024

Conversation

lazappi
Copy link
Member

@lazappi lazappi commented Nov 25, 2024 •
edited
Loading

Add the scPRINT foundation model as a method

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes

  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

lazappi added 11 commits November 4, 2024 09:17
@lazappi lazappi requested a review from rcannood November 25, 2024 15:20
rcannood
rcannood approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Minor suggestion in allowing the model to be passed directly

lazappi and others added 3 commits November 26, 2024 13:56
@rcannood rcannood merged commit 52ccedb into main Nov 26, 2024
2 checks passed
@rcannood rcannood deleted the feature/no-ref/add-scPRINT branch November 26, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcannood rcannood rcannood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lazappi @rcannood