Skip to content

Added provision to assert job status, updated HPO script for disconne… #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

abhijeet-dhumal
Copy link
Contributor

@abhijeet-dhumal abhijeet-dhumal commented Aug 21, 2024

Depends on PR : project-codeflare/codeflare-common#61

Description

How Has This Been Tested?

Manually :

image

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@abhijeet-dhumal abhijeet-dhumal force-pushed the add-job-status-assertion-flow branch from 6c84161 to aa7ed18 Compare August 21, 2024 10:06
@abhijeet-dhumal abhijeet-dhumal force-pushed the add-job-status-assertion-flow branch 6 times, most recently from 6768350 to ccbc2be Compare August 27, 2024 08:49
@abhijeet-dhumal abhijeet-dhumal marked this pull request as ready for review August 27, 2024 08:55
…cted and removed local-queue parameter usage from cluster configuration to make it optional
@abhijeet-dhumal abhijeet-dhumal force-pushed the add-job-status-assertion-flow branch from 9d96a7f to 872fa9c Compare August 27, 2024 13:01
…DK options and reduced polling logic time interval to 1 sec
@abhijeet-dhumal abhijeet-dhumal force-pushed the add-job-status-assertion-flow branch from 49c4e00 to 4298349 Compare August 27, 2024 13:40
@astefanutti
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 232750d into opendatahub-io:main Aug 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants