-
Notifications
You must be signed in to change notification settings - Fork 59
Added provision to assert job status, updated HPO script for disconne… #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
openshift-merge-bot
merged 3 commits into
opendatahub-io:main
from
abhijeet-dhumal:add-job-status-assertion-flow
Aug 27, 2024
Merged
Added provision to assert job status, updated HPO script for disconne… #208
openshift-merge-bot
merged 3 commits into
opendatahub-io:main
from
abhijeet-dhumal:add-job-status-assertion-flow
Aug 27, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astefanutti
reviewed
Aug 21, 2024
6c84161
to
aa7ed18
Compare
6768350
to
ccbc2be
Compare
astefanutti
reviewed
Aug 27, 2024
sutaakar
reviewed
Aug 27, 2024
sutaakar
reviewed
Aug 27, 2024
sutaakar
reviewed
Aug 27, 2024
sutaakar
reviewed
Aug 27, 2024
…cted and removed local-queue parameter usage from cluster configuration to make it optional
9d96a7f
to
872fa9c
Compare
sutaakar
reviewed
Aug 27, 2024
sutaakar
reviewed
Aug 27, 2024
sutaakar
reviewed
Aug 27, 2024
…DK options and reduced polling logic time interval to 1 sec
49c4e00
to
4298349
Compare
/lgtm |
sutaakar
approved these changes
Aug 27, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on PR : project-codeflare/codeflare-common#61
Description
How Has This Been Tested?
Manually :
Merge criteria: