-
Notifications
You must be signed in to change notification settings - Fork 59
Automated test for LLM Finetune Deepspeed demo #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated test for LLM Finetune Deepspeed demo #197
Conversation
890c82b
to
e38f772
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the reasoning behind copying all of the necessary training files to this tests/odh/ray_finetune_demo
? The files should exist already under examples/ray-finetune-llm-deepspeed
.
This would cause any updates for the example to also be updated here
tests/odh/resources/ray_finetune_demo/ray_finetune_llm_deepspeed.ipynb
Outdated
Show resolved
Hide resolved
Hey Mark, I have updated some of the files a bit to make it compatible with paths specified during test execution and also some tweaks can be made in future for upcoming tests.. |
tests/odh/resources/ray_finetune_demo/ray_finetune_llm_deepspeed.ipynb
Outdated
Show resolved
Hide resolved
tests/odh/resources/ray_finetune_demo/ray_finetune_llm_deepspeed.ipynb
Outdated
Show resolved
Hide resolved
tests/odh/resources/ray_finetune_demo/ray_finetune_llm_deepspeed.ipynb
Outdated
Show resolved
Hide resolved
tests/odh/resources/ray_finetune_demo/ray_finetune_llm_deepspeed.ipynb
Outdated
Show resolved
Hide resolved
tests/odh/resources/ray_finetune_demo/ray_finetune_llm_deepspeed.ipynb
Outdated
Show resolved
Hide resolved
e38f772
to
d4d06a3
Compare
76a46e9
to
f8f1bb2
Compare
61d72f9
to
09181c7
Compare
09181c7
to
304c810
Compare
03e4879
to
2419ec0
Compare
9b93dbf
to
b87c91a
Compare
b87c91a
to
9d022c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
RHOAIENG-9185
Related PRs / Depends on:
project-codeflare/codeflare-common#59
project-codeflare/codeflare-common#61
#208
How Has This Been Tested?
Merge criteria: