Skip to content

Automated test for LLM Finetune Deepspeed demo #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

abhijeet-dhumal
Copy link
Contributor

@abhijeet-dhumal abhijeet-dhumal commented Jul 28, 2024

Description

RHOAIENG-9185

Related PRs / Depends on:
project-codeflare/codeflare-common#59
project-codeflare/codeflare-common#61
#208

How Has This Been Tested?

export CODEFLARE_TEST_OUTPUT_DIR=/home/abdhumal/abhidev/RedHatDev/distributed-workloads \
NOTEBOOK_USER_NAME=regular-user \
NOTEBOOK_USER_TOKEN=<auth-token> \
ODH_NAMESPACE=redhat-ods-applications \
NOTEBOOK_IMAGE=quay.io/modh/odh-generic-data-science-notebook@sha256:9d7f80080a453bcf7dee01b986df9ee811ee74f6f433c601a8b67d283c160547 \
AWS_ACCESS_KEY_ID=<s3-access-key> \
AWS_SECRET_ACCESS_KEY=<s3-secret-key> \
AWS_STORAGE_BUCKET=<storage-bucket-name> \
AWS_DEFAULT_REGION=<aws-default-region>
go test -timeout 15m -v ./tests/odh -run TestRayFinetuneLlmDeepspeedDemoLlama_2_7b
go test -timeout 15m -v ./tests/odh -run TestRayFinetuneLlmDeepspeedDemoLlama_31_8b

image (124)

image (118)

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reasoning behind copying all of the necessary training files to this tests/odh/ray_finetune_demo? The files should exist already under examples/ray-finetune-llm-deepspeed.

This would cause any updates for the example to also be updated here

@abhijeet-dhumal
Copy link
Contributor Author

What was the reasoning behind copying all of the necessary training files to this tests/odh/ray_finetune_demo? The files should exist already under examples/ray-finetune-llm-deepspeed.

This would cause any updates for the example to also be updated here

Hey Mark, I have updated some of the files a bit to make it compatible with paths specified during test execution and also some tweaks can be made in future for upcoming tests..
So keeping example files and test files separate seems feasible to me in this case.. please correct me if I'm wrong
Thank you for reviewing @Bobbins228 !!

@abhijeet-dhumal abhijeet-dhumal changed the title Automate LLM Finetune Deepspeed demo Automate LLM Finetune Deepspeed demo test Aug 1, 2024
@abhijeet-dhumal abhijeet-dhumal changed the title Automate LLM Finetune Deepspeed demo test Automated test for LLM Finetune Deepspeed demo Aug 1, 2024
@abhijeet-dhumal abhijeet-dhumal force-pushed the automate-llm-finetune-deepspeed-demo branch from e38f772 to d4d06a3 Compare August 2, 2024 14:36
@abhijeet-dhumal abhijeet-dhumal marked this pull request as draft August 6, 2024 10:54
@abhijeet-dhumal abhijeet-dhumal force-pushed the automate-llm-finetune-deepspeed-demo branch 3 times, most recently from 76a46e9 to f8f1bb2 Compare August 9, 2024 12:13
@abhijeet-dhumal abhijeet-dhumal marked this pull request as ready for review August 9, 2024 12:16
@openshift-ci openshift-ci bot requested a review from jbusche August 9, 2024 12:16
@abhijeet-dhumal abhijeet-dhumal force-pushed the automate-llm-finetune-deepspeed-demo branch from 61d72f9 to 09181c7 Compare August 16, 2024 09:11
@abhijeet-dhumal abhijeet-dhumal force-pushed the automate-llm-finetune-deepspeed-demo branch from 09181c7 to 304c810 Compare August 26, 2024 14:20
@abhijeet-dhumal abhijeet-dhumal force-pushed the automate-llm-finetune-deepspeed-demo branch 2 times, most recently from 03e4879 to 2419ec0 Compare August 27, 2024 08:35
@abhijeet-dhumal abhijeet-dhumal force-pushed the automate-llm-finetune-deepspeed-demo branch 2 times, most recently from 9b93dbf to b87c91a Compare August 27, 2024 15:07
@abhijeet-dhumal abhijeet-dhumal force-pushed the automate-llm-finetune-deepspeed-demo branch from b87c91a to 9d022c1 Compare August 27, 2024 15:35
Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

Copy link

openshift-ci bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7f2dbf7 into opendatahub-io:main Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants