[GSoC 2017] Obstruction Free #1233

binbin-xu · 2017-06-18T11:15:07Z

This pullrequest changes

First commit with some dummy functions to get familiar with PR procedure.

Added the interface headers, readme, bib files of the obstruction-free method in the module of xphoto, with the first part implementation code of building a multiscale pyramid for the input image sequences.

@garybradski

Sample, including source / result images
Tests
Tutorial

…uction free method.

sovrasov · 2017-06-21T10:03:14Z

modules/xphoto/CMakeLists.txt

@@ -1,2 +1,2 @@
 set(the_description "Addon to basic photo module")
-ocv_define_module(xphoto opencv_core opencv_imgproc WRAP python)
+ocv_define_module(xphoto opencv_core opencv_imgproc opencv_highgui WRAP python)


Why do you need higui here? We are trying to reduce dependencies for each module.

Thank you very much for pointing it out. You are right. highgui was used originally for showing the processed images. I will remove this dependency to the sample file.

sovrasov · 2017-06-21T10:04:51Z

modules/xphoto/include/opencv2/xphoto/obstruction_free.hpp

@@ -0,0 +1,77 @@
+/*M///////////////////////////////////////////////////////////////////////////////////////


This long header should be replaced with a short one:

// This file is part of OpenCV project. // It is subject to the license terms in the LICENSE file found in the top-level directory // of this distribution and at http://opencv.org/license.html.

Thank you very much for pointing it out. I will modify the header part.

sovrasov · 2017-06-21T10:06:12Z

modules/xphoto/src/obstruction_free.cpp

@@ -0,0 +1,80 @@
+/*M///////////////////////////////////////////////////////////////////////////////////////


Same about the outdated long license header.

Thank you very much for pointing it out. I will modify the header part accordingly.

sovrasov · 2017-06-21T10:07:23Z

modules/xphoto/src/obstruction_free.cpp

+
+#ifndef __OPENCV_OBSTRUCTION_FREE_CPP__
+#define __OPENCV_OBSTRUCTION_FREE_CPP__
+#ifdef __cplusplus


__cplusplus check is not useful anymore, so it's better to get rid of that.

Thank you very much for pointing it out. I will remove this line.

…w and opencv_ximgproc may be removed later.

…, where opencv_optflow and opencv_ximgproc may be removed later.

…pencv_contrib into obstructionfree-gsoc * 'obstructionfree-gsoc' of https://github.com/binbin-xu/opencv_contrib: add dependency of opencv_optflow, opencv_ximgproc, and opencv_calib3d, where opencv_optflow and opencv_ximgproc may be removed later. Conflicts: modules/xphoto/CMakeLists.txt

…ype.

binbin-xu · 2017-08-29T15:30:53Z

Summary to the “Computational Occlusion Removal in Image Inpainting” project:

Code:
The commits I made can be seen in the PR link (#1233), which summarizes the commits I have made.

Work done:
The goal of the project was to implemented a new image inpainting method to remove opaque obstructions or reflections in the photo. The work I have completed so far including the initialization part and the first part in the alternative optimization.

Work left to be finished:

The visual surface interpolation. In the current framework, I temporally used the interpolation method in Epicflow algorithm to generate the visual surface for dense edge flow. However, in the case of opaque occlusions, this interpolation algorithm does not work well. By discussing with the author Dr. Richard Szeliski, the visual surface interpolation can refer to the work done by Dr. Dilip Krishnan: http://cs.nyu.edu/~dilip/research/abf/ and http://www.cs.huji.ac.il/~raananf/projects/hsc/
The sparse edge flow algorithm, which uses belief propagation to match only edges in one frame to another. I am sorry but I have been stuck in this part for a long time and have not finished it.
I derived the solutions to the alternative optimization equations, which can be seen in the file: https://groups.google.com/group/opencv-gsoc-2017/attach/4b56565812b20/gsoc-derivatives-eq15.pdf
I am sorry but my derived equations have not been fully verified by other experienced persons, though the original author Tianfan mentioned it seemed correct in a rough glance.
However, the second part has not been implemented yet. I am sincerely sorry for it.

Acknowledgements:
I appreciate very much my mentor Gary for accepting me into this project and Steven and Maksim for patiently answering my possibly very stupid questions in the Slack Channel and the original authors Tianfan and Dr. Szeliski for solving my seemingly endless puzzles through email. I would like to apologize again for not being able to finish this project totally and hope I can continue finishing this project later in my spare time.

Yours sincerely,
Binbin Xu

First PR. Added the interface headers, readme, bib files of the obstr…

6d30fce

…uction free method.

binbin-xu changed the title ~~First PR for gsoc obstruction free project~~ [GSoC 2017] First PR for gsoc obstruction free project Jun 18, 2017

binbin-xu added 2 commits June 18, 2017 21:19

Fix CmakeLists

0486e04

fix the conversion between size_t and int on the Win64 system

1499141

sovrasov reviewed Jun 21, 2017

View reviewed changes

binbin-xu added 3 commits June 22, 2017 01:21

fix the problems commented by the reviewer sovrasov

378a595

fix typo

1d8d33a

Initialization part

05434ce

binbin-xu changed the title ~~[GSoC 2017] First PR for gsoc obstruction free project~~ [GSoC 2017] Obstruction Free Jul 18, 2017

binbin-xu added 12 commits July 19, 2017 11:06

add dependency of outflow, opencv_ximgproc, and calib3d, where outflo…

1974f45

…w and opencv_ximgproc may be removed later.

add dependency of opencv_optflow, opencv_ximgproc, and opencv_calib3d…

a18e2ec

…, where opencv_optflow and opencv_ximgproc may be removed later.

add dependency of opencv_optflow, opencv_ximgproc, and opencv_calib3d…

63c641d

…, where opencv_optflow and opencv_ximgproc may be removed later.

amend typo and dependency

5d453cf

amend head file dependency

c694e46

fix warnings and errors

0bca4ca

fix declarations and type conversions

0b426a2

fix the mistakes in copying from local files

fdac8cd

add weights calculation parts

5835871

1. Fix the conversion between int and size_t. 2. Fix the varepsilon t…

e9c6f9c

…ype.

add D_x^TD_x + D_y^TD_y

9a0caa8

berak mentioned this pull request Oct 13, 2018

rfc: stalled commits here #1838

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[GSoC 2017] Obstruction Free #1233

[GSoC 2017] Obstruction Free #1233

binbin-xu commented Jun 18, 2017 •

edited by alalek

Loading

Uh oh!

sovrasov Jun 21, 2017

Uh oh!

binbin-xu Jun 21, 2017

Uh oh!

sovrasov Jun 21, 2017

Uh oh!

binbin-xu Jun 21, 2017

Uh oh!

sovrasov Jun 21, 2017

Uh oh!

binbin-xu Jun 21, 2017

Uh oh!

sovrasov Jun 21, 2017

Uh oh!

binbin-xu Jun 21, 2017

Uh oh!

binbin-xu commented Aug 29, 2017

Uh oh!

Uh oh!

		@@ -0,0 +1,77 @@
		/*M///////////////////////////////////////////////////////////////////////////////////////

		@@ -0,0 +1,80 @@
		/*M///////////////////////////////////////////////////////////////////////////////////////

[GSoC 2017] Obstruction Free #1233

Are you sure you want to change the base?

[GSoC 2017] Obstruction Free #1233

Conversation

binbin-xu commented Jun 18, 2017 • edited by alalek Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This pullrequest changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

binbin-xu commented Aug 29, 2017

Uh oh!

Uh oh!

binbin-xu commented Jun 18, 2017 •

edited by alalek

Loading