-
Notifications
You must be signed in to change notification settings - Fork 15
Resolve extra classpath lazily when configuring Protobuf generation tasks #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andrewparmet
wants to merge
15
commits into
main
Choose a base branch
from
lazy-init-extra-classpath
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
937a724
try resolving extra classpath lazily
andrewparmet 4fac433
try to fix
andrewparmet 61c69a7
Update ProtobufBuild.kt
andrewparmet ee4b46f
Revert "Update ProtobufBuild.kt"
andrewparmet 92697da
lint
andrewparmet cbb2552
proper task
andrewparmet 1130721
simplify
andrewparmet 6fde671
ws
andrewparmet 49b68b9
Merge branch 'main' into lazy-init-extra-classpath
andrewparmet 149ea05
not an input
andrewparmet e009f08
Merge branch 'main' into lazy-init-extra-classpath
andrewparmet d7eb937
alternative formulation without a task
andrewparmet 943e493
names
andrewparmet e2c9f55
lost ref
andrewparmet c55b703
simplify
andrewparmet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out this isn't reliable - extractIncludeJvmTestProto is considered
main
because it doesn't perfectly match p-g-p's criteria. I haven't looked how deeply that check failing affects our config.