Resolve extra classpath lazily when configuring Protobuf generation tasks #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewparmet
changed the title
This reverts commit 61c69a7.
ogolberg
reviewed
Jun 5, 2025
andrewparmet
changed the title
andrewparmet
commented
Jun 13, 2025
| private fun extraClasspath(project: Project, task: GenerateProtoTask): String { | ||
| var extensions: FileCollection = project.configurations.getByName(EXTENSIONS) | ||
|
|
||
| if (task.isTest) { |
There was a problem hiding this comment.
Turns out this isn't reliable - extractIncludeJvmTestProto is considered main because it doesn't perfectly match p-g-p's criteria. I haven't looked how deeply that check failing affects our config.
ogolberg
reviewed
Jun 18, 2025
| extractIncludeProtoTasks().forEach { task -> | ||
| val isTest = task.isTestTask() | ||
| if ((!test && !isTest) || (test && isTest)) { | ||
| logger.log(DEBUG_LOG_LEVEL, "Adding input files to task ${task.name} from ${it.taskName}") |
There was a problem hiding this comment.
This constant maps to debug right now, but I like to be able to change the value to make logs noisier at will. I can back out that pattern in a separate PR but don't want to right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this warning:
Definitely open to less hacky approaches...