Skip to content

feat: update proto to 1.7.0 #5643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 48 commits into from
May 28, 2025

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented May 2, 2025

Updates the protos submodule to v1.7.0. Does not update the code using the submodule. All changes are backwards compatible. Should have no impact on users or contributors, but paves the way to add new features like Entities.

Adds e2e test to ensure a trace, metric, and log are exported as expected

Fixes #5208

@dyladan dyladan requested a review from a team as a code owner May 2, 2025 19:27
Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.03%. Comparing base (c193502) to head (4833cea).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5643   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files         310      310           
  Lines        7998     7998           
  Branches     1615     1615           
=======================================
  Hits         7601     7601           
  Misses        397      397           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dyladan - did you do also some manual tests to verify that this is working? We have some unit and integration tests but there are no end-to-end tests and we've had things break in the past in unexpected ways.

Edit: linked issue #5208

@dyladan
Copy link
Member Author

dyladan commented May 23, 2025

@dyladan - did you do also some manual tests to verify that this is working? We have some unit and integration tests but there are no end-to-end tests and we've had things break in the past in unexpected ways.

Edit: linked issue #5208

I added an e2e test that exports to a collector and dumps the output to a file which can be manually verified

@david-luna
Copy link
Contributor

Hi @dyladan

I'm sharing here the commit that updated the protos version for other reviewers just in case. I was naive to think it would appear something in the files tab 😅

Have you thought to update submodule.md files in otlp-transformer to point to the last commit?
Also the otlp-grpc-exporter-base does not have a submodule anymore. I guess we could remove submodule.md in that package.

@pichlermarc pichlermarc dismissed their stale review May 28, 2025 10:40

blockers addressed.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you for working on this. 🙌

@dyladan
Copy link
Member Author

dyladan commented May 28, 2025

@trentm I added a README ptal

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh - looks like the readme also needs an update.

Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo the same comment on the README (s/make/npm run/) that Marc made.

@dyladan
Copy link
Member Author

dyladan commented May 28, 2025

Oops forgot to remove make references. Done

@dyladan dyladan enabled auto-merge May 28, 2025 14:56
@dyladan dyladan added this pull request to the merge queue May 28, 2025
Merged via the queue into open-telemetry:main with commit 5736c49 May 28, 2025
25 checks passed
@dyladan dyladan deleted the update-proto branch May 28, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[otlp-transformer] update protos submodule to latest version
5 participants