-
Notifications
You must be signed in to change notification settings - Fork 897
feat: update proto to 1.7.0 #5643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update proto to 1.7.0 #5643
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5643 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 310 310
Lines 7998 7998
Branches 1615 1615
=======================================
Hits 7601 7601
Misses 397 397 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added an e2e test that exports to a collector and dumps the output to a file which can be manually verified |
Hi @dyladan I'm sharing here the commit that updated the protos version for other reviewers just in case. I was naive to think it would appear something in the files tab 😅 Have you thought to update |
…elemetry-js into update-proto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thank you for working on this. 🙌
@trentm I added a README ptal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh - looks like the readme also needs an update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, modulo the same comment on the README (s/make/npm run/) that Marc made.
Oops forgot to remove make references. Done |
Updates the
protos
submodule tov1.7.0
. Does not update the code using the submodule. All changes are backwards compatible. Should have no impact on users or contributors, but paves the way to add new features like Entities.Adds e2e test to ensure a trace, metric, and log are exported as expected
Fixes #5208