Skip to content

feat: add event name to event API and SDK #5707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 2, 2025

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented May 23, 2025

Leaving as a draft because when I went to test it I found the proto still needs to be updated. This is what I get for saying this would be "simple" yesterday.

Depends on #5643

Adds event name to the logger emit event API as required by spec.

Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.04%. Comparing base (55f8c20) to head (4af0086).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5707   +/-   ##
=======================================
  Coverage   95.03%   95.04%           
=======================================
  Files         310      310           
  Lines        7998     8008   +10     
  Branches     1615     1616    +1     
=======================================
+ Hits         7601     7611   +10     
  Misses        397      397           
Files with missing lines Coverage Δ
...erimental/packages/api-logs/src/types/LogRecord.ts 100.00% <ø> (ø)
...ckages/otlp-transformer/src/logs/internal-types.ts 100.00% <ø> (ø)
...tal/packages/otlp-transformer/src/logs/internal.ts 100.00% <ø> (ø)
experimental/packages/sdk-logs/src/LogRecord.ts 98.27% <100.00%> (+0.16%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dyladan dyladan added this to the Logs API/SDK GA milestone May 28, 2025
@dyladan dyladan marked this pull request as ready for review May 28, 2025 21:01
@dyladan dyladan requested a review from a team as a code owner May 28, 2025 21:01
@svetlanabrennan
Copy link
Contributor

LGTM. Just needs an update on the PR title and description since it's not in draft mode anymore.

@dyladan dyladan changed the title [draft] feat: add event name to event API and SDK feat: add event name to event API and SDK May 30, 2025
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

dyladan and others added 2 commits June 2, 2025 13:27
@dyladan dyladan added this pull request to the merge queue Jun 2, 2025
Merged via the queue into open-telemetry:main with commit 56df3c0 Jun 2, 2025
25 checks passed
@dyladan dyladan deleted the event-name branch June 2, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants