-
Notifications
You must be signed in to change notification settings - Fork 897
feat: add event name to event API and SDK #5707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5707 +/- ##
=======================================
Coverage 95.03% 95.04%
=======================================
Files 310 310
Lines 7998 8008 +10
Branches 1615 1616 +1
=======================================
+ Hits 7601 7611 +10
Misses 397 397
🚀 New features to boost your workflow:
|
svetlanabrennan
approved these changes
May 29, 2025
LGTM. Just needs an update on the PR title and description since it's not in draft mode anymore. |
beeme1mr
approved these changes
May 30, 2025
pichlermarc
approved these changes
Jun 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Co-authored-by: Marc Pichler <marcpi@edu.aau.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving as a draft because when I went to test it I found the proto still needs to be updated. This is what I get for saying this would be "simple" yesterday.Depends on #5643
Adds event name to the logger emit event API as required by spec.