[chore] refactor(contrib): remove replace directive for go-ieproxy package
#678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…package The replacement for the package `github.com/mattn/go-ieproxy` is currently in effect and replaces `v0.0.11` of the package with version `v0.0.1`. I believe this replacement is not necessary anymore, as the issue mattn/go-ieproxy#45 was fixed mattn/go-ieproxy#47 in v0.0.11.
codeboten
approved these changes
Oct 3, 2024
songy23
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replacement for the package
github.com/mattn/go-ieproxyis currently in effect and replacesv0.0.11of the package with versionv0.0.1. I believe this replacement is not necessary anymore, as the issue mattn/go-ieproxy#45 was fixed in mattn/go-ieproxy#47 in v0.0.11.If I understand the original issue correctly, it being fixed can be verified by a successful Windows build in GitHub Actions. Perhaps @codeboten you can take a look at this and possibly correct me, as you originally introduced this replace directive.