Skip to content

[chore] remove unnecessary go-ieproxy replace #35592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2024
Merged

[chore] remove unnecessary go-ieproxy replace #35592

merged 1 commit into from
Oct 3, 2024

Conversation

codeboten
Copy link
Contributor

This replace is no longer needed.

@codeboten
[chore] remove unnecessary go-ieproxy replace
ebedaa4 
This replace is no longer needed.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested review from a team, crobert-1 and dmitryax as code owners October 3, 2024 18:46
@github-actions github-actions bot added cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol receiver/sqlquery SQL query receiver labels Oct 3, 2024
@codeboten
Copy link
Contributor Author

Removing this here as a check that the tests still pass before merging open-telemetry/opentelemetry-collector-releases#678

crobert-1
crobert-1 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codeboten codeboten merged commit 938182f into open-telemetry:main Oct 3, 2024
156 checks passed
@codeboten codeboten deleted the codeboten/chore-unused-replace branch October 3, 2024 19:39
@github-actions github-actions bot added this to the next release milestone Oct 3, 2024
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
@codeboten @jriguera
[chore] remove unnecessary go-ieproxy replace (open-telemetry#35592)
5e9ae3d 
This replace is no longer needed.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
ghost pushed a commit to sematext/opentelemetry-collector-contrib that referenced this pull request Oct 9, 2024
@codeboten @AkhigbeEromo
[chore] remove unnecessary go-ieproxy replace (open-telemetry#35592)
03c9116 
This replace is no longer needed.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@songy23 songy23 songy23 approved these changes

@crobert-1 crobert-1 crobert-1 approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

Assignees

@mx-psi mx-psi

Labels

cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol receiver/sqlquery SQL query receiver

Projects

None yet

Milestone

v0.111.0

Development

Successfully merging this pull request may close these issues.

4 participants

@codeboten @songy23 @crobert-1 @mx-psi