Skip to content

[chore] Remove deprecated macos-13 runner, Add macos-14 runner #43653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
Merged

[chore] Remove deprecated macos-13 runner, Add macos-14 runner #43653

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8046a0
[chore] Remove deprecated macos-13 runner, Add macos-15-intel runner
v1v Oct 20, 2025
9f1a53b
test on macos-14 only
v1v Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test-darwin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [macos-13]
os: [macos-15-intel]
Copy link
Contributor

@codeboten codeboten Oct 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this match the oldest os specified on line 52?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow up question do we need to specify intel here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good questions, a bit of context:

The macos-13 is intel based, while macos-14 and macos-15 are arm-based, so the only way to keep the same arch was by using the macos-15-intel runner.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its fine if we test on arm, based on the platforms we support, arm64 is a higher priority than arm64 https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/platform-support.md#tier-2--secondary-support

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied your suggestion:

Thanks for the link to the support, that's quite nice

timeout-minutes: 30
runs-on: ${{ matrix.os }}
steps:
Expand Down