-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[chore] Remove deprecated macos-13 runner, Add macos-14 runner #43653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
| fail-fast: false | ||
| matrix: | ||
| os: [macos-13] | ||
| os: [macos-15-intel] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this match the oldest os specified on line 52?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follow up question do we need to specify intel here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good questions, a bit of context:
The macos-13 is intel based, while macos-14 and macos-15 are arm-based, so the only way to keep the same arch was by using the macos-15-intel runner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its fine if we test on arm, based on the platforms we support, arm64 is a higher priority than arm64 https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/platform-support.md#tier-2--secondary-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
|
Thank you for your contribution @v1v! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
Description
Similarly done in the past, see #38337
Ref: https://github.blog/changelog/2025-09-19-github-actions-macos-13-runner-image-is-closing-down/
Link to tracking issue
n/a
Testing
n/a
Documentation
n/a