Skip to content

Conversation

@v1v
Copy link
Contributor

@v1v v1v commented Oct 20, 2025

Description

Similarly done in the past, see #38337

Ref: https://github.blog/changelog/2025-09-19-github-actions-macos-13-runner-image-is-closing-down/

Link to tracking issue

n/a

Testing

n/a

Documentation

n/a

@v1v v1v requested a review from a team as a code owner October 20, 2025 11:31
@v1v v1v requested a review from edmocosta October 20, 2025 11:31
@github-actions github-actions bot added the first-time contributor PRs made by new contributors label Oct 20, 2025
@github-actions
Copy link
Contributor

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

@songy23 songy23 added the ci-cd CI, CD, testing, build issues label Oct 20, 2025
@github-actions
Copy link
Contributor

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

fail-fast: false
matrix:
os: [macos-13]
os: [macos-15-intel]
Copy link
Contributor

@codeboten codeboten Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this match the oldest os specified on line 52?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow up question do we need to specify intel here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good questions, a bit of context:

The macos-13 is intel based, while macos-14 and macos-15 are arm-based, so the only way to keep the same arch was by using the macos-15-intel runner.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its fine if we test on arm, based on the platforms we support, arm64 is a higher priority than arm64 https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/platform-support.md#tier-2--secondary-support

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied your suggestion:

Thanks for the link to the support, that's quite nice

Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@v1v v1v changed the title [chore] Remove deprecated macos-13 runner, Add macos-15-intel runner [chore] Remove deprecated macos-13 runner, Add macos-14 runner Oct 20, 2025
@codeboten codeboten merged commit 6ea248d into open-telemetry:main Oct 20, 2025
186 checks passed
@otelbot
Copy link
Contributor

otelbot bot commented Oct 20, 2025

Thank you for your contribution @v1v! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help.

@github-actions github-actions bot added this to the next release milestone Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd CI, CD, testing, build issues first-time contributor PRs made by new contributors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants