Skip to content

fix: add retry policy to grpc calls. #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import json
import logging
import threading
import time
Expand Down Expand Up @@ -80,6 +81,44 @@ def _generate_channel(self, config: Config) -> grpc.Channel:
("grpc.initial_reconnect_backoff_ms", config.retry_backoff_ms),
("grpc.max_reconnect_backoff_ms", config.retry_backoff_max_ms),
("grpc.min_reconnect_backoff_ms", config.deadline_ms),
(
"grpc.service_config",
json.dumps(
{
"methodConfig": [
{
"name": [
{"service": "flagd.sync.v1.FlagSyncService"},
{"service": "flagd.evaluation.v1.Service"},
],
"retryPolicy": {
"maxAttempts": 3,
"initialBackoff": "1s",
"maxBackoff": "5s",
"backoffMultiplier": 2.0,
"retryableStatusCodes": [
"CANCELLED",
"UNKNOWN",
"INVALID_ARGUMENT",
"NOT_FOUND",
"ALREADY_EXISTS",
"PERMISSION_DENIED",
"RESOURCE_EXHAUSTED",
"FAILED_PRECONDITION",
"ABORTED",
"OUT_OF_RANGE",
"UNIMPLEMENTED",
"INTERNAL",
"UNAVAILABLE",
"DATA_LOSS",
"UNAUTHENTICATED",
],
},
}
]
}
),
),
]
if config.tls:
channel_args = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,44 @@ def _generate_channel(self, config: Config) -> grpc.Channel:
("grpc.initial_reconnect_backoff_ms", config.retry_backoff_ms),
("grpc.max_reconnect_backoff_ms", config.retry_backoff_max_ms),
("grpc.min_reconnect_backoff_ms", config.stream_deadline_ms),
(
"grpc.service_config",
json.dumps(
{
"methodConfig": [
{
"name": [
{"service": "flagd.sync.v1.FlagSyncService"},
{"service": "flagd.evaluation.v1.Service"},
],
"retryPolicy": {
"maxAttempts": 3,
"initialBackoff": "1s",
"maxBackoff": "5s",
"backoffMultiplier": 2.0,
"retryableStatusCodes": [
"CANCELLED",
"UNKNOWN",
"INVALID_ARGUMENT",
"NOT_FOUND",
"ALREADY_EXISTS",
"PERMISSION_DENIED",
"RESOURCE_EXHAUSTED",
"FAILED_PRECONDITION",
"ABORTED",
"OUT_OF_RANGE",
"UNIMPLEMENTED",
"INTERNAL",
"UNAVAILABLE",
"DATA_LOSS",
"UNAUTHENTICATED",
],
},
}
]
}
),
),
]
if config.default_authority is not None:
options.append(("grpc.default_authority", config.default_authority))
Expand Down