fix: add retry policy to grpc calls. #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
=======================================
Coverage 93.99% 94.00%
=======================================
Files 18 18
Lines 983 984 +1
=======================================
+ Hits 924 925 +1
Misses 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aepfli
force-pushed
the
feat/retry_connection_topic_with_istio
branch
2 times, most recently
from
d06302b to
ad3febc
Compare
Some error codes are not on the stream, eg. istio is sending some special ones, and we already used to implement the same logic in java to bypass this issue. Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli
force-pushed
the
feat/retry_connection_topic_with_istio
branch
from
ad3febc to
ae7f066
Compare
beeme1mr
reviewed
Jun 10, 2025
providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/grpc.py
Show resolved
Hide resolved
toddbaert
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some error codes are not on the stream, e.g., Istio is sending some special ones, and we already implemented the same logic in Java to bypass this issue. see open-feature/java-sdk-contrib#1261