Skip to content

fix: make flag keys unique as a workaround for selector issue #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

chrfwow
Copy link
Contributor

@chrfwow chrfwow commented Mar 18, 2025

This PR

Makes the flag keys of feature flags unique to work around a selector issue where the last flag with a key overwrites all other flags with the same key, even when using different selectors (open-feature/flagd#1596)

Related Issues

Workaround for open-feature/flagd#1596 to fix open-feature/python-sdk-contrib#119

Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@toddbaert toddbaert changed the title make flag keys unique as a workaround for selector issue fix: make flag keys unique as a workaround for selector issue Mar 18, 2025
@toddbaert toddbaert self-requested a review March 18, 2025 19:14
@toddbaert toddbaert merged commit 099895a into open-feature:main Mar 18, 2025
3 of 4 checks passed
@chrfwow chrfwow deleted the unique-flag-keys-workaround branch March 19, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flagd] Update in-process resolver to support flag metadata
2 participants