Skip to content

feat: add support for flagd flag metadata #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Mar 25, 2025
Merged

feat: add support for flagd flag metadata #215

merged 34 commits into from
Mar 25, 2025

Conversation

chrfwow
Copy link
Contributor

@chrfwow chrfwow commented Mar 18, 2025 •
edited
Loading

This PR

Adds support for flag and flag set metadata in flagd

Related Issues

Fixes #119

Waiting for open-feature/flagd-testbed#242

Follow-up Tasks

I will open a PR for additional e2e tests in the flagd testbed

@codecov Codecov
Copy link

codecov bot commented Mar 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.99%. Comparing base (9bf2e42) to head (d99ad2f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   94.00%   93.99%   -0.01%     
==========================================
  Files          18       18              
  Lines         950      983      +33     
==========================================
+ Hits          893      924      +31     
- Misses         57       59       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

chrfwow added 25 commits March 18, 2025 11:15
@chrfwow
add support for metadata in flagd
0521bd0 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
reformatting
a76bcf6 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
fix type errors
eab778b 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
fix type errors and fmt
390144d 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
fix type errors and fmt
7bf74e1 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
fix format
ed1f91f 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
fix format, add tests
a6d8715 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
fix format
3cc2048 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
fix format
c9e5ed7 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
switch to new version of flagd testbed
94967fb 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
switch to new version of flagd testbed v2
11666ff 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
fix zero value errors
69da51c 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
Merge branch 'main' into flag-metadata
7487c29
@chrfwow
Merge branch 'main' into flag-metadata
d9c1c4f
@chrfwow
switch to new version of flagd testbed v3
3eff272 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
switch to new version of flagd testbed v3
850ce81 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
switch to new version of flagd testbed v4
f2b37b5 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
switch to new version of flagd testbed v5
503d3e5 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
switch to new version of flagd testbed v6
257a421 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
minor improvements, adjust to workaround for fladg issue
761f650 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
update test harness v10000
494fb74 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
fix format
2a991b9 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
attempt to fix tests
0c4f28f 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
fix format
ed60818 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
fix failing tests, upgrade test harness
b2ad90c 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow chrfwow marked this pull request as ready for review March 21, 2025 08:35
@chrfwow chrfwow requested a review from a team as a code owner March 21, 2025 08:35
@chrfwow
fix format
8822464 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
fix format
519c3a5 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
aepfli
aepfli approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you this looks really cool, especially the extension of our gherkin tests.

@gruebel I do not have any power here, would you do us the honor of a review please ;)

gruebel
gruebel approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 🍻 just string formatting needs a some adjustments. don't forget to run ruff locally, will probably result in slight different line breaks.

@gruebel gruebel mentioned this pull request Mar 24, 2025
Closed
1 task
chrfwow and others added 6 commits March 25, 2025 13:28
@chrfwow @gruebel
Update providers/openfeature-provider-flagd/src/openfeature/contrib/p…
e054a4f 
…rovider/flagd/resolvers/process/flags.py

Co-authored-by: Anton Grübel <anton.gruebel@gmail.com>
Signed-off-by: chrfwow <christian.lutnik@dynatrace.com>
@chrfwow @gruebel
Update providers/openfeature-provider-flagd/src/openfeature/contrib/p…
21e52b7 
…rovider/flagd/resolvers/process/flags.py

Co-authored-by: Anton Grübel <anton.gruebel@gmail.com>
Signed-off-by: chrfwow <christian.lutnik@dynatrace.com>
@chrfwow @gruebel
Update providers/openfeature-provider-flagd/src/openfeature/contrib/p…
f5a376b 
…rovider/flagd/resolvers/process/flags.py

Co-authored-by: Anton Grübel <anton.gruebel@gmail.com>
Signed-off-by: chrfwow <christian.lutnik@dynatrace.com>
@chrfwow
fix string format
aaff161 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
fix format
85b70f6 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@gruebel
Merge branch 'main' into flag-metadata
d99ad2f
@gruebel gruebel merged commit 6dc72c0 into open-feature:main Mar 25, 2025
22 checks passed
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Merged
@chrfwow chrfwow deleted the flag-metadata branch March 25, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aepfli aepfli aepfli approved these changes

@gruebel gruebel gruebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[flagd] Update in-process resolver to support flag metadata
3 participants
@chrfwow @aepfli @gruebel