-
Notifications
You must be signed in to change notification settings - Fork 0
feat: data initialisation, criteria and assessment parameters refactor #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
This was referenced May 21, 2025
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
… basis Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
… a dictionary mapping criteria ID to metadata and bounds - updating helpers etc Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
ConnectedSystems
requested changes
May 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor comments, feel free to merge once addressed
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Co-authored-by: Takuya Iwanaga <takuyai@gmail.com>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
TODO: Double check the percentile values for Hs and Tp (waves)
Swap tooltip text Co-authored-by: Peter Baker <87056634+PeterBaker0@users.noreply.github.com>
Filled in criteria metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing criteria
This has the effect of
a) allowing users to run jobs only restricting criteria of interest
b) ensuring regional and suitability assessment caches are shared where they should be, but invalidated if defaults change (by ensuring the query param dict passed to the hash function includes ALL criteria, not just those specified in the request)
Criteria, data initialisation and assessment params refactor
Rewrites the data initialisation, caching, criteria bounds etc all into a unified data structure which is fully typed. Did use structs all the way through but found that naming criteria in the structs ended up being over-engineered compared to having const global arrays/dicts of available criteria.
This has lots of side benefits like fixing regional assessment file caching, properly merging default ranges and user ranges (including into hash), and making criteria easy to add/exclude.
The process to add new criteria now should be easy i.e.
There is also a lot of additional runtime validation on data loading relating to presence of necessary fields.