-
Notifications
You must be signed in to change notification settings - Fork 0
feat: improved logging, scaling and documentation #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
…n task types to track counts Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
❌ Code formatting check failed. Please run |
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
https://www.desmos.com/calculator/h2hxuqi2gk Can be used to play with scaling function params |
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Ideally we'd have test coverage of this code, but it's tricky. At some point, I'd like to discuss if we want to create tests for this and how to approach it
|
||
try { | ||
// Build set of distinct worker types from the tracked workers | ||
const clusterArns = new Set(this.trackedWorkers.map(w => w.clusterArn)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally would have tests for these functions, but they're not so easy to test, would need to mock things. maybe an integration test? we can discuss testing approaches later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - there are possible options - but agree it's a bit tricky
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
❌ Code formatting check failed. Please run |
Improves the capacity manager implementation with
Other changes
Also updates job interfaces to add wave height/period and make inputs optional - see open-AIMS/ReefGuideAPI.jl#67
Could do later