-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(core): upgrade axios to 1.12.0 to address CVE-2025-58754 #32712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
View your CI Pipeline Execution ↗ for commit f6bfe1c
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naturally a DOS vulnerability is not relevant to Nx at all but we can get this merged to help with noise on your end.
@JamesHenry I totally agree. Just feel like it's always a good idea to address security advisories even though Nx doesn't have a public-facing API so a DOS attack vector is not relevant here. |
@terrymun Sorry you need to redo your commit to match the required conventions (you can see what I did to the PR title). We have a precommit hook to catch this so you must have bypassed it? |
@JamesHenry Whoops, my bad! I pushed with |
Changes look good to me.. the CI failures look unrelated other than the commit message? Hopefully it passes once you update your commit 🤞 |
b331afb
to
67ab37e
Compare
@FrozenPandaz @JamesHenry Thanks for the tips. I've fixed the incorrect commit message and pushed. Hope it will pass CI checks now :) |
67ab37e
to
733d322
Compare
@terrymun If you hit some flake again better to ping us to rerun rather than force push up, because the workflows won't run without our approval anyway |
@JamesHenry Apologies for the force push. The linting tests are still failing tho, and I'm not sure what I can do to fix them. |
@terrymun I believe the rspack issues were addressed, please could you resolve the conflicts (sorry about that) |
733d322
to
40a67d4
Compare
|
Name | Link |
---|---|
🔨 Latest commit | 40a67d4 |
@terrymun I have rebased and addressed the conflicts for you so that this can proceed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
Analysis of PR Intent:
The pull request upgrades axios from version ^1.8.3 to ^1.12.0 across the Nx monorepo to address CVE-2025-58754, a high-severity security vulnerability. The changes update axios dependencies in the root package.json, packages/create-nx-workspace, and packages/nx, along with the corresponding pnpm-lock.yaml updates.
Failure Classification and Reasoning:
- Rspack Build Failures (examples-angular-rspack-zoneless-csr-i18n:build, examples-angular-rspack-csr-i18n:build):
The error "The 'compilation' argument must be an instance of Compilation. This usually occurs when multiple versions of '@rspack/core' are used" explicitly indicates a dependency version conflict issue. Examining the pnpm-lock.yaml changes reveals that the axios upgrade triggered pnpm to resolve multiple versions of @rspack/core (1.5.0 and 1.5.2) in the dependency tree.
This is classified as 'environment_state' because:
- The error message explicitly states it's caused by multiple @rspack/core versions
- The failure is in build tooling dependency resolution, not application code
- The axios upgrade inadvertently affected transitive dependency resolution
- This is a side effect of the package manager's resolution algorithm
- No code logic was changed that would cause Rspack compilation to fail
The proper fix would be to ensure @rspack/core is pinned to a single version across the workspace, but this is a dependency management issue, not a code issue introduced by the security patch.
- E2E Test Failure (e2e-angular:e2e-ci--src/cypress-component-tests-app.test.ts):
The error "listen EADDRINUSE: address already in use 127.0.0.1:8080" is a port conflict error where the test attempts to bind to a port that's already occupied.
This is classified as 'flaky_task' because:
- Port conflicts are classic flaky test symptoms related to improper test cleanup or timing
- The error has no logical connection to upgrading axios (an HTTP client library)
- This type of error typically occurs when previous test processes haven't fully terminated
- The failure is environmental/timing-dependent, not deterministic
Conclusion:
No code changes are warranted. The Rspack build failures are caused by dependency resolution side effects that require dependency management fixes, not code fixes. The E2E test failure is a flaky test infrastructure issue unrelated to the security upgrade. The axios security patch itself is valid and necessary.
A code change would likely not resolve this issue, so no action was taken.
⚙️ An Nx Cloud workspace admin can disable these reviews in workspace settings.
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior Nx is currently using a vulnerable version of axios (<1.12.0) which has a reported high-level vulnerability [CVE-2025-58754](https://www.cve.org/CVERecord?id=CVE-2025-58754). This is being flagged by GitHub Advanced Security on a Nx-powered monorepo: <img width="1260" height="712" alt="Screenshot 2025-09-12 at 09 42 56" src="https://github.com/user-attachments/assets/251b47c7-07d1-4c21-aafb-0811554d8861" /> ## Expected Behavior Nx should be using a patched version of axios (≥1.12.0) that addresses said vulnerability. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # --------- Co-authored-by: Colum Ferry <cferry09@gmail.com> (cherry picked from commit 9ca711f)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Nx is currently using a vulnerable version of axios (<1.12.0) which has a reported high-level vulnerability CVE-2025-58754. This is being flagged by GitHub Advanced Security on a Nx-powered monorepo:
Expected Behavior
Nx should be using a patched version of axios (≥1.12.0) that addresses said vulnerability.
Related Issue(s)
Fixes #