fix(core): upgrade axios to 1.12.0 to address CVE-2025-58754 #32954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Name | Link |
|---|---|
| 🔨 Latest commit | e4edf32 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@JamesHenry / @FrozenPandaz nice to meet you all! I would really appreciate if you could review it and push downstream (mostly to reduce noise). Happy to address some more vulnerabilities later as well! |
|
Thanks @lexpank, I've updated the original PR to resolve the conflicts. This PR would not have been possible to proceed with because of what it changed in the lockfile around optionalDependencies as well FYI |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Nx is currently using a vulnerable version of axios (<1.12.0) which has a reported high-level vulnerability CVE-2025-58754. This is being flagged by GitHub Advanced Security. This is a lighter version of #32712 (also rebased), going from branch to make is easier for me to rebase.
Expected Behavior
Nx should be using a patched version of axios (≥1.12.0) that addresses said vulnerability.