Skip to content

fix(js): correct TypeScript types for notification.delete.pending event #9325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 21, 2025
Merged

fix(js): correct TypeScript types for notification.delete.pending event #9325

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3be9805
fix(js): correct TypeScript types for notification.delete.pending event
DipakHalkude Oct 8, 2025
3fc8e99
Merge branch 'next' into fix-notification-delete-types
scopsy Oct 21, 2025
544064d
Delete packages/js/src/event-emitter/event-emitter.test.ts
scopsy Oct 21, 2025
936f535
Remove outdated comments from event and notification types
scopsy Oct 21, 2025
7d47058
Merge branch 'fix-notification-delete-types' of https://github.com/Di…
scopsy Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/js/src/event-emitter/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ type NotificationUnreadEvents = BaseEvents<'notification.unread', UnreadArgs, No
type NotificationSeenEvents = BaseEvents<'notification.seen', SeenArgs, Notification>;
type NotificationArchiveEvents = BaseEvents<'notification.archive', ArchivedArgs, Notification>;
type NotificationUnarchiveEvents = BaseEvents<'notification.unarchive', UnarchivedArgs, Notification>;
type NotificationDeleteEvents = BaseEvents<'notification.delete', DeletedArgs, void>;
type NotificationDeleteEvents = BaseEvents<'notification.delete', DeletedArgs, Notification>;
type NotificationSnoozeEvents = BaseEvents<'notification.snooze', SnoozeArgs, Notification>;
type NotificationUnsnoozeEvents = BaseEvents<'notification.unsnooze', UnsnoozeArgs, Notification>;
type NotificationCompleteActionEvents = BaseEvents<'notification.complete_action', CompleteArgs, Notification>;
Expand Down
Loading