fix(js): correct TypeScript types for notification.delete.pending event #9325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change NotificationDeleteEvents from void to Notification type - Update DeletedArgs interface to properly include notification - Add comprehensive test for notification.delete.pending event types - Fixes TypeScript error when accessing event.args.notification - Resolves issue novuhq#9297 Fixes novuhq#9297
✅ Deploy Preview for dashboard-v2-novu-staging canceled.
|
|
@LetItRock could you give this a look? 🙏 |
Deleted obsolete FIX comments in event-emitter/types.ts and notifications/types.ts to clean up type definitions and improve code clarity.
scopsy
approved these changes
Oct 21, 2025
|
Thank you so much for merging this PR! 🙏 Wishing you and the entire team a very Happy Diwali! 🪔✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9297
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer