feat: make all instance attributes on HasRid subclasse private #263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent PR of mine, @stefanv had an excellent observation:
HasRid
subclasses as such:DataSource
and the wholeRID
fiasco re:Channel
s.Being the quick typer i am (aka regex) i have gone ahead and turned all API attributes into readonly properties.
Now, you might say, "but drake! our dataclasses are frozen, users should know they can't update these fields even in the first place!"
ds.properties = {"very cool property name": "kinda lame property value"}
, but they sure can still dods.properties["python is cool"] = "but rust is wack"
.dataclasses
to even consider this.